Skip to content

FIX: Removing dependencies on VRModule #2251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
+1 −27
Open

FIX: Removing dependencies on VRModule #2251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
751b6af
Removing dependencies on VRModule
RogPodge Oct 2, 2025
db1e773
Added changelog entry
RogPodge Oct 2, 2025
ca5f257
Merge branch 'develop' of https://github.com/Unity-Technologies/Input…
RogPodge Oct 3, 2025
c1f3927
Adding back API so as not to be a breaking change
RogPodge Oct 6, 2025
83cd60a
Merge branch 'develop' into vrmodule-deprecation
RogPodge Oct 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Packages/com.unity.inputsystem/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ however, it has to be formatted properly to pass verification tests.
- Fixed an issue in `Keyboard` where the sub-script operator would return a `null` key control for the deprecated key `Key.IMESelected`. Now, an aliased `KeyControl`mapping to the IMESelected bit is returned for compability reasons. It is still strongly advised to not rely on this key since `IMESelected` bit isn't strictly a key and will be removed from the `Key` enumeration type in a future major revision. [ISXB-1541](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1541).
- Fixed InputControl picker not updating correctly when the Input Actions Window was dirty. [ISXB-1221](https://issuetracker.unity3d.com/product/unity/issues/guid/ISXB-1221)
- Fixed formatting issues on processor documentation page
- Fixed an issue where a warning would be appear due to code referencing the obsolete com.unity.modules.vr package.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the message. However, the warning part should have already been covered by Fixed the compilation warnings when used with Unity 6.4 (ISX-2349). just a few lines above in the changelog (as part of that change we also added a suppression message that made this warning go away). Provided that, maybe we should put this note in another section and say something like Changed: Input System no longer depends on the obsolete com.unity.modules.vr package ?


## [1.14.2] - 2025-08-05

Expand Down
20 changes: 0 additions & 20 deletions Packages/com.unity.inputsystem/InputSystem/Plugins/XR/TrackedPoseDriver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,16 +418,6 @@ protected void Reset()
/// </summary>
protected virtual void Awake()
{
#if UNITY_INPUT_SYSTEM_ENABLE_VR && ENABLE_VR
if (HasStereoCamera(out var cameraComponent))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also be able to delete the private HasStereoCamera method too since it isn't called anywhere else other than these Awake and OnDestroy methods.

{
// The Unity 6.4+ replacement for this call has to be figured later
// See https://jira.unity3d.com/browse/XR-7591
#pragma warning disable CS0618
UnityEngine.XR.XRDevice.DisableAutoXRCameraTracking(cameraComponent, true);
#pragma warning restore CS0618
}
#endif
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Can we remove the now empty Awake and OnDestroy as well? Thanks

Copy link
Collaborator

@chris-massie chris-massie Oct 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No because they are protected virtual and users may have created derived scripts that use them. It would be a breaking change to remove the methods.


/// <summary>
Expand Down Expand Up @@ -459,16 +449,6 @@ protected void OnDisable()
/// </summary>
protected virtual void OnDestroy()
{
#if UNITY_INPUT_SYSTEM_ENABLE_VR && ENABLE_VR
if (HasStereoCamera(out var cameraComponent))
{
// The Unity 6.4+ replacement for this call has to be figured later
// See https://jira.unity3d.com/browse/XR-7591
#pragma warning disable CS0618
UnityEngine.XR.XRDevice.DisableAutoXRCameraTracking(cameraComponent, false);
#pragma warning restore CS0618
}
#endif
}

/// <summary>
Expand Down
5 changes: 0 additions & 5 deletions Packages/com.unity.inputsystem/InputSystem/Unity.InputSystem.asmdef
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@
"expression": "2.0.3",
"define": "DISABLE_BUILTIN_INPUT_SYSTEM_WINDOWSMR"
},
{
"name": "com.unity.modules.vr",
"expression": "1.0.0",
"define": "UNITY_INPUT_SYSTEM_ENABLE_VR"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we also need to remove code that utilize UNITY_INPUT_SYSTEM_ENABLE_VR?

Copy link
Collaborator Author

@RogPodge RogPodge Oct 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were no code paths left in the InputSystem or Engine repository that utilized the define UNITY_INPUT_SYSTEM_ENABLE_VR

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

},
{
"name": "com.unity.modules.xr",
"expression": "1.0.0",
Expand Down
1 change: 0 additions & 1 deletion Packages/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@
"com.unity.modules.unitywebrequestwww": "1.0.0",
"com.unity.modules.vehicles": "1.0.0",
"com.unity.modules.video": "1.0.0",
"com.unity.modules.vr": "1.0.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we have to support all Unity versions down to 2021.3 xLTS. Is this change aligned with that? Just asking to make sure. CC @ekcoh for viz.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

legacy VR module was used to support VR development before Unity 2019, so should have no effects on 2021.3+

"com.unity.modules.wind": "1.0.0",
"com.unity.modules.xr": "1.0.0"
}
Expand Down
1 change: 0 additions & 1 deletion Tools/CodeAnalyzerTestProject/Packages/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
"com.unity.modules.unitywebrequestwww": "1.0.0",
"com.unity.modules.vehicles": "1.0.0",
"com.unity.modules.video": "1.0.0",
"com.unity.modules.vr": "1.0.0",
"com.unity.modules.wind": "1.0.0",
"com.unity.modules.xr": "1.0.0"
}
Expand Down
Loading