-
Notifications
You must be signed in to change notification settings - Fork 456
ci: Improvement of PR template #3628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
EmandM
approved these changes
Aug 27, 2025
michalChrobot
added a commit
that referenced
this pull request
Aug 28, 2025
## Purpose of this PR This is a backport of #3628 Following on N4E investigation I added a functionality of automatic assignement of netcode-qa as a PR reviewer if one of the checkboxes is marked. Additionally note that **Jira Ticket** section is now mandatory buy of course you can always write N/A under it I also modified github action runners to use the recommended one ### Jira ticket MTT-12822 ## Documentation Included comments in the scripts ## Testing & QA Will check one of the checkboxes to see if netcode-qa is being properly added as reviewer, other then that no specific testing is required ### Functional Testing _Manual testing :_ - [ ] `Manual testing done` _Automated tests:_ - [ ] `Covered by existing automated tests` - [ ] `Covered by new automated tests` _Does the change require QA team to:_ - [ ] `Review automated tests`? - [ ] `Execute manual tests`? - [x] `Provide feedback about the PR` If any boxes above are checked the QA team will be automatically added as a PR reviewer. ## Backports [Will do](#3628) --------- Co-authored-by: Emma <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
This follows up on initial PR #3582.
Following on N4E investigation I added a functionality of automatic assignement of netcode-qa as a PR reviewer if one of the checkboxes is marked.
Additionally note that Jira Ticket section is now mandatory buy of course you can always write N/A under it
I also modified github action runners to use the recommended one
Jira ticket
MTT-12822
Documentation
Included comments in the scripts
Testing & QA
Will check one of the checkboxes to see if netcode-qa is being properly added as reviewer, other then that no specific testing is required
Functional Testing
Manual testing :
Manual testing done
Automated tests:
Covered by existing automated tests
Covered by new automated tests
Does the change require QA team to:
Review automated tests
?Execute manual tests
?Provide feedback about the PR
If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports
#3629