Skip to content

Conversation

michalChrobot
Copy link
Collaborator

@michalChrobot michalChrobot commented Aug 27, 2025

Purpose of this PR

This follows up on initial PR #3582.
Following on N4E investigation I added a functionality of automatic assignement of netcode-qa as a PR reviewer if one of the checkboxes is marked.

Additionally note that Jira Ticket section is now mandatory buy of course you can always write N/A under it

I also modified github action runners to use the recommended one

Jira ticket

MTT-12822

Documentation

Included comments in the scripts

Testing & QA

Will check one of the checkboxes to see if netcode-qa is being properly added as reviewer, other then that no specific testing is required

Functional Testing

Manual testing :

  • Manual testing done

Automated tests:

  • Covered by existing automated tests
  • Covered by new automated tests

Does the change require QA team to:

  • Review automated tests?
  • Execute manual tests?
  • Provide feedback about the PR

If any boxes above are checked the QA team will be automatically added as a PR reviewer.

Backports

#3629

@michalChrobot michalChrobot self-assigned this Aug 27, 2025
@michalChrobot michalChrobot marked this pull request as ready for review August 27, 2025 12:28
michalChrobot added a commit that referenced this pull request Aug 28, 2025
## Purpose of this PR
This is a backport of
#3628

Following on N4E investigation I added a functionality of automatic
assignement of netcode-qa as a PR reviewer if one of the checkboxes is
marked.

Additionally note that **Jira Ticket** section is now mandatory buy of
course you can always write N/A under it

I also modified github action runners to use the recommended one

### Jira ticket
MTT-12822

## Documentation
Included comments in the scripts

## Testing & QA
Will check one of the checkboxes to see if netcode-qa is being properly
added as reviewer, other then that no specific testing is required

### Functional Testing

_Manual testing :_
- [ ] `Manual testing done`

_Automated tests:_
- [ ] `Covered by existing automated tests`
- [ ] `Covered by new automated tests`

_Does the change require QA team to:_

- [ ] `Review automated tests`?
- [ ] `Execute manual tests`?
- [x] `Provide feedback about the PR`

If any boxes above are checked the QA team will be automatically added
as a PR reviewer.

## Backports
[Will
do](#3628)

---------

Co-authored-by: Emma <[email protected]>
@michalChrobot michalChrobot merged commit fbb3457 into develop-2.0.0 Aug 28, 2025
7 of 26 checks passed
@michalChrobot michalChrobot deleted the pr-template-improvement branch August 28, 2025 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants