-
Notifications
You must be signed in to change notification settings - Fork 456
ci: Improvement of PR template #3628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6a82d59
Updated pr template and verification job
michalChrobot d3a2501
ubdated runners to use recommended unity ones
michalChrobot 5075733
automatic QA assigning
michalChrobot 65b4a2f
updated secret name
michalChrobot 87414e2
Added one more option about QA request
michalChrobot 29aee9f
section test reduction
michalChrobot 9307675
Renamed in the same was as in N4E
michalChrobot 40b1fb1
Update .github/pull_request_template.md
michalChrobot cfe40d8
Merge branch 'develop-2.0.0' into pr-template-improvement
michalChrobot 27af61c
reverted image to ubuntu-latest
michalChrobot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ on: | |
|
||
jobs: | ||
stale: | ||
runs-on: ubuntu-latest | ||
runs-on: unity-linux-runner | ||
permissions: | ||
issues: write | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
# This workflow depend on the content of .github/pull_request_template.md file, which should contain the required sections that the script checks for | ||
# This also works in parallel with .github/workflows/pr-verification.yml which validates PR format | ||
# In contrast to .github/workflows/pr-verification.yml, this workflow is conditional and aims to ease the process of requesting QA review by automatically assigning the QA team whenever a checkbox is marked | ||
|
||
# In case that the given checkboxes are marked the script will automatically add netcode-qa team as a reviewer. | ||
|
||
name: 'Assign QA Reviewer' | ||
|
||
on: | ||
pull_request: | ||
types: [opened, edited, synchronize, reopened] | ||
|
||
jobs: | ||
assign-qa: | ||
# This job only runs if the checkbox in the PR description exist and is checked. | ||
if: > | ||
contains(github.event.pull_request.body, '- [x] `Review automated tests`') || | ||
contains(github.event.pull_request.body, '- [x] `Execute manual tests`') || | ||
contains(github.event.pull_request.body, '- [x] `Provide feedback about the PR`') | ||
runs-on: unity-linux-runner | ||
|
||
|
||
steps: | ||
|
||
- name: 'Assign QA Team' | ||
uses: actions/github-script@v7 | ||
with: | ||
github-token: ${{ secrets.GH_TOKEN }} | ||
script: | | ||
github.rest.pulls.requestReviewers({ | ||
owner: context.repo.owner, | ||
repo: context.repo.repo, | ||
pull_number: context.issue.number, | ||
team_reviewers: ['netcode-qa'] | ||
}); | ||
console.log('Assigned netcode-qa for review.'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.