Fix: Return 401 instead of 500 for empty credentials #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Empty username or password returns HTTP 500 instead of HTTP 401, leaking information about credential handling and enabling enumeration attacks.
Changes
UnityAuthenticationProvider.authenticate(): Added early validation for null/empty credentials before processing, returningCREDENTIALS_DO_NOT_MATCHfailure consistent with other auth failureslogin_failsWithEmptyPassword()andlogin_failsWithEmptyUsername()to verify 401 responseOriginal prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.