Skip to content

Fix: Return 401 instead of 500 for empty credentials #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix: Return 401 instead of 500 for empty credentials #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d8ee917
Initial plan
Copilot Jan 7, 2026
cb664e2
Fix: Return 401 instead of 500 for empty credentials (issue #40)
Copilot Jan 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion UnityAuth/src/main/java/io/unityfoundation/auth/UnityAuthenticationProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,13 @@ private User findUser(AuthenticationRequest<?, ?> authRequest) {
@Override
public @NonNull Publisher<AuthenticationResponse> authenticate(
@NonNull AuthenticationRequest<Object, Object> authenticationRequest) {
return Mono.fromCallable(() -> findUser(authenticationRequest))
if (authenticationRequest.getIdentity() == null ||
authenticationRequest.getIdentity().toString().isEmpty() ||
authenticationRequest.getSecret() == null ||
authenticationRequest.getSecret().toString().isEmpty()) {
return Mono.just(AuthenticationResponse.failure(CREDENTIALS_DO_NOT_MATCH.toString()));
}
return Mono.fromCallable(() -> findUser(authenticationRequest))
.subscribeOn(Schedulers.boundedElastic())
.flatMap(user -> {
AuthenticationFailed authenticationFailed = validate(user, authenticationRequest);
Expand Down
19 changes: 19 additions & 0 deletions UnityAuth/src/test/java/io/unityfoundation/UnityIamTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import io.micronaut.http.HttpResponse;
import io.micronaut.http.HttpStatus;
import io.micronaut.http.client.HttpClient;
import io.micronaut.http.client.exceptions.HttpClientResponseException;
import io.micronaut.http.client.annotation.Client;
import io.micronaut.security.authentication.UsernamePasswordCredentials;
import io.micronaut.security.token.render.BearerAccessRefreshToken;
Expand Down Expand Up @@ -311,4 +312,22 @@ private String login(String username) {
BearerAccessRefreshToken bearer = rsp.body();
return bearer.getAccessToken();
}

@Test
void login_failsWithEmptyPassword() {
UsernamePasswordCredentials creds = new UsernamePasswordCredentials("[email protected]", "");
HttpRequest<?> request = HttpRequest.POST("/api/login", creds);
HttpClientResponseException exception = assertThrows(HttpClientResponseException.class, () ->
client.toBlocking().exchange(request, BearerAccessRefreshToken.class));
assertEquals(HttpStatus.UNAUTHORIZED, exception.getStatus());
}

@Test
void login_failsWithEmptyUsername() {
UsernamePasswordCredentials creds = new UsernamePasswordCredentials("", "test");
HttpRequest<?> request = HttpRequest.POST("/api/login", creds);
HttpClientResponseException exception = assertThrows(HttpClientResponseException.class, () ->
client.toBlocking().exchange(request, BearerAccessRefreshToken.class));
assertEquals(HttpStatus.UNAUTHORIZED, exception.getStatus());
}
}