Add bit for 3PE stoppage to UrRtdeSafetyStatusBits #401
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #401 +/- ##
==========================================
- Coverage 42.83% 42.71% -0.13%
==========================================
Files 99 99
Lines 8626 8623 -3
Branches 1170 1170
==========================================
- Hits 3695 3683 -12
- Misses 4652 4660 +8
- Partials 279 280 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| IS_FAULT = 9, | ||
| IS_STOPPED_DUE_TO_SAFETY = 10 | ||
| IS_STOPPED_DUE_TO_SAFETY = 10, | ||
| IS_SYSTEM_THREE_POSITION_ENABLING_STOPPED = 11 |
There was a problem hiding this comment.
I would suggest following the RTDE documentation regarding the naming:
| IS_SYSTEM_THREE_POSITION_ENABLING_STOPPED = 11 | |
| IS_3PE_INPUT_ACTIVE = 11 |
There was a problem hiding this comment.
Thanks @urfeex for the feedback.
So, I picked this name by analogy with what I found in SafetyStatus: SafetyStatus::ROBOT_EMERGENCY_STOP goes to UrRtdeSafetyStatusBits::IS_ROBOT_EMERGENCY_STOPPED, so I analogized SafetyStatus::SYSTEM_THREE_POSITION_ENABLING_STOP to the proposed UrRtdeSafetyStatusBits::IS_SYSTEM_THREE_POSITION_ENABLING_STOPPED. Just let me know which you prefer. If you still prefer the one you proposed here over the analogized one, I'll just accept your edit and you can merge.
2 participants
Fixes #394.
I think this is really all that is required, unless you have unit tests that you need, but I didn't find any results in the codebase for other symbols from this enumeration.