Skip to content

Tool param propagation #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 28, 2022
Merged

Tool param propagation #13

merged 2 commits into from
Jan 28, 2022

Conversation

livanov93
Copy link
Contributor

@livanov93 livanov93 commented Jan 27, 2022 •
edited
Loading

@livanov93 livanov93 requested a review from fmauch January 27, 2022 16:32
@livanov93 livanov93 changed the title Start tool communication Tool param propagation Jan 27, 2022
destogl
destogl approved these changes Jan 27, 2022
View reviewed changes
Copy link
Contributor

@destogl destogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me.

@fmauch fmauch force-pushed the start-tool-communication branch from 801a2b4 to f997f2b Compare January 28, 2022 09:57
fmauch
fmauch approved these changes Jan 28, 2022
View reviewed changes
Copy link
Contributor

@fmauch fmauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Merging as soon as CI is green.

@fmauch fmauch merged commit 007469a into ros2 Jan 28, 2022
@fmauch fmauch deleted the start-tool-communication branch January 28, 2022 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@fmauch fmauch fmauch approved these changes

@destogl destogl destogl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@livanov93 @fmauch @destogl