Skip to content

Conversation

@urfeex
Copy link
Member

@urfeex urfeex commented Jan 14, 2025

This PR aims at removing all build warnings for Humble.

Waiting for realtime-tools to be released before this is ready-to-review.

@urfeex urfeex added the humble Relevant for humble and higher ROS versions label Jan 14, 2025
@urfeex urfeex force-pushed the humble_no_warnings branch from df5eed0 to 03694b7 Compare January 20, 2025 07:49
@urfeex urfeex force-pushed the humble_no_warnings branch from 03694b7 to fbb18a4 Compare February 3, 2025 07:17
@urfeex urfeex marked this pull request as ready for review February 3, 2025 07:51
@urfeex urfeex requested a review from a team February 3, 2025 07:51
Copy link

@SarveshMalladi SarveshMalladi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its still failing humble build

@urfeex
Copy link
Member Author

urfeex commented Feb 3, 2025

Humble main is expected to fail here until the next sync. Merging.

@urfeex urfeex merged commit 4fd0b24 into UniversalRobots:humble Feb 3, 2025
6 of 7 checks passed
@urfeex urfeex deleted the humble_no_warnings branch February 3, 2025 10:10
@kdeshp-prof
Copy link

It is not possible to build the package on humble because of #include <realtime_tools/realtime_box_best_effort.hpp>

The file does not exist while the file <realtime_tools/realtime_box_best_effort.h> does exist and then it builds fine

@urfeex
Copy link
Member Author

urfeex commented Feb 7, 2025

It is not possible to build the package on humble because of #include <realtime_tools/realtime_box_best_effort.hpp>

The file does not exist while the file <realtime_tools/realtime_box_best_effort.h> does exist and then it builds fine

You experience this because ros-controls/realtime_tools@393a384 is released, but not yet synchronized to main. This is also, why our binary-testing build succeeds, while the binary main build fails. Building this package from the head branch might require building upstream packages from source from time to time. Please see the source build instructions for details.

If you don't want to go through this trouble, you might just use our binary installation packages instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

humble Relevant for humble and higher ROS versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants