Skip to content

Conversation

@urfeex
Copy link
Member

@urfeex urfeex commented Jan 17, 2025

As Iron is EOL since end of November we should clearly state that here, as well.

@urfeex urfeex requested a review from a team January 17, 2025 08:33
@codecov
Copy link

codecov bot commented Jan 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 3.77%. Comparing base (1b121b7) to head (8bf8838).
Report is 385 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1239      +/-   ##
========================================
+ Coverage   3.59%   3.77%   +0.18%     
========================================
  Files         13     395     +382     
  Lines        947   43513   +42566     
  Branches     152    6407    +6255     
========================================
+ Hits          34    1643    +1609     
- Misses       843   41727   +40884     
- Partials      70     143      +73     
Flag Coverage Δ
unittests 3.77% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@urrsk urrsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also clean up the builds for Foxy and Galactic as well

@urfeex
Copy link
Member Author

urfeex commented Jan 20, 2025

We should also clean up the builds for Foxy and Galactic as well

Done in 8bf8838

@urfeex urfeex requested a review from urrsk January 20, 2025 10:44
@urfeex urfeex merged commit 3b68f1e into UniversalRobots:main Jan 20, 2025
14 checks passed
@urfeex urfeex deleted the deprecate_iron branch January 20, 2025 13:28
mergify bot pushed a commit that referenced this pull request Jan 20, 2025
* Remove Iron from the active distributions
* Remove unused foxy and galactic builds

(cherry picked from commit 3b68f1e)

# Conflicts:
#	.github/workflows/iron-binary-main.yml
#	README.md
urfeex added a commit that referenced this pull request Jan 20, 2025
* Remove Iron from the active distributions
* Remove unused foxy and galactic builds

(cherry picked from commit 3b68f1e)

# Conflicts:
#	.github/workflows/iron-binary-main.yml
#	README.md
urfeex pushed a commit that referenced this pull request Jan 21, 2025
* Remove Iron from the active distributions
* Remove unused foxy and galactic builds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants