Skip to content

Conversation

@urfeex
Copy link
Member

@urfeex urfeex commented Mar 5, 2025

Update to new get_optional API from ros2_control. Let's try to keep the warnings at 0.

@urfeex urfeex requested a review from a team March 5, 2025 15:36
@codecov
Copy link

codecov bot commented Mar 11, 2025

Codecov Report

Attention: Patch coverage is 0% with 72 lines in your changes missing coverage. Please review.

Project coverage is 5.69%. Comparing base (1b121b7) to head (8bc8813).
Report is 405 commits behind head on main.

Files with missing lines Patch % Lines
ur_controllers/src/gpio_controller.cpp 0.00% 44 Missing ⚠️
...trollers/src/passthrough_trajectory_controller.cpp 0.00% 17 Missing ⚠️
ur_controllers/src/ur_configuration_controller.cpp 0.00% 4 Missing ⚠️
ur_controllers/src/freedrive_mode_controller.cpp 0.00% 3 Missing ⚠️
ur_controllers/src/force_mode_controller.cpp 0.00% 2 Missing ⚠️
...rollers/src/scaled_joint_trajectory_controller.cpp 0.00% 1 Missing ⚠️
...ontrollers/src/speed_scaling_state_broadcaster.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1289      +/-   ##
========================================
+ Coverage   3.59%   5.69%   +2.10%     
========================================
  Files         13      31      +18     
  Lines        947    3057    +2110     
  Branches     152     374     +222     
========================================
+ Hits          34     174     +140     
- Misses       843    2881    +2038     
+ Partials      70       2      -68     
Flag Coverage Δ
unittests 5.69% <0.00%> (+2.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@urfeex urfeex requested a review from urmahp March 12, 2025 08:32
@urfeex urfeex force-pushed the update_interfaces_get_optional branch from bb241df to 8bc8813 Compare March 12, 2025 08:32
@urfeex urfeex merged commit 57d8fab into UniversalRobots:main Mar 12, 2025
12 of 14 checks passed
@urfeex urfeex deleted the update_interfaces_get_optional branch March 12, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants