Skip to content

Conversation

@urfeex
Copy link
Member

@urfeex urfeex commented Mar 24, 2025

When specifying higher-order splines while no velocity or acceleration state interfaces are configured for the robot, the controller attempted to read from the non-existing interfaces. This PR adds a check whether those interfaces are actually configured before attempting to read from them.

@urfeex urfeex requested a review from a team March 24, 2025 14:51
@codecov
Copy link

codecov bot commented Mar 24, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 5.66%. Comparing base (1b121b7) to head (c84ed09).
Report is 412 commits behind head on main.

Files with missing lines Patch % Lines
...trollers/src/passthrough_trajectory_controller.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1314      +/-   ##
========================================
+ Coverage   3.59%   5.66%   +2.07%     
========================================
  Files         13      31      +18     
  Lines        947    3072    +2125     
  Branches     152     375     +223     
========================================
+ Hits          34     174     +140     
- Misses       843    2896    +2053     
+ Partials      70       2      -68     
Flag Coverage Δ
unittests 5.66% <0.00%> (+2.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@urrsk urrsk changed the title Fix passthrough controllerto not read non-existing state_interfaces Fix passthrough controller to not read non-existing state_interfaces Mar 26, 2025
@urfeex urfeex merged commit 65679b2 into UniversalRobots:main Mar 26, 2025
13 of 14 checks passed
mergify bot pushed a commit that referenced this pull request Mar 26, 2025
…1314)

* passthrough_trajectory: Add a test with a full quintic trajectory

* Check for state interfaces being present before attempting to read from it

(cherry picked from commit 65679b2)

# Conflicts:
#	ur_controllers/src/passthrough_trajectory_controller.cpp
@urfeex urfeex deleted the fix_passthrough_controller branch March 26, 2025 13:53
urfeex added a commit that referenced this pull request Mar 28, 2025
…1314)

* passthrough_trajectory: Add a test with a full quintic trajectory

* Check for state interfaces being present before attempting to read from it
urfeex pushed a commit that referenced this pull request Mar 28, 2025
…1314) (#1316)

* passthrough_trajectory: Add a test with a full quintic trajectory

* Check for state interfaces being present before attempting to read from it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants