Skip to content

Conversation

@urfeex
Copy link
Member

@urfeex urfeex commented May 19, 2025

The open_loop parameter has been removed upstream (see ros-controls/ros2_controllers#1598), so we'll have to remove it from here, as well.

The open_loop parameter has been removed upstream, so we'll have to
remove it from here, as well.
@urfeex urfeex requested a review from a team May 19, 2025 12:03
@codecov
Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 5.06%. Comparing base (1b121b7) to head (3f08b20).
Report is 436 commits behind head on main.

Files with missing lines Patch % Lines
...rollers/src/scaled_joint_trajectory_controller.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main   #1362      +/-   ##
========================================
+ Coverage   3.59%   5.06%   +1.47%     
========================================
  Files         13      33      +20     
  Lines        947    3436    +2489     
  Branches     152     424     +272     
========================================
+ Hits          34     174     +140     
- Misses       843    3260    +2417     
+ Partials      70       2      -68     
Flag Coverage Δ
unittests 5.06% <0.00%> (+1.47%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@urfeex urfeex mentioned this pull request May 19, 2025
@urfeex urfeex merged commit 6cbcaf1 into UniversalRobots:main May 20, 2025
12 of 15 checks passed
@urfeex urfeex deleted the sjtc_remove_deprecated_code branch May 20, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants