Set minimal velocity tolerance in passthrough trajectory test #1443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running a quintic spline with the passthrough trajectory test there can be a minimal velocity deviation at the end of the trajectory due to how the robot interpolates motions. With a velocity tolerance of 0.0 there is a chance that we hit this tolerance.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1443 +/- ##
========================================
+ Coverage 3.59% 5.11% +1.52%
========================================
Files 13 33 +20
Lines 947 3404 +2457
Branches 152 427 +275
========================================
+ Hits 34 174 +140
- Misses 843 3228 +2385
+ Partials 70 2 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
urmahp
approved these changes
Jul 2, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
* Set minimal velocity tolerance in passthrough trajectory test When running a quintic spline with the passthrough trajectory test there can be a minimal velocity deviation at the end of the trajectory due to how the robot interpolates motions. With a velocity tolerance of 0.0 there is a chance that we hit this tolerance. * Explicitly switch on controllers in test where they are needed (cherry picked from commit 1cd3ac5)
mergify bot
pushed a commit
that referenced
this pull request
Jul 2, 2025
* Set minimal velocity tolerance in passthrough trajectory test When running a quintic spline with the passthrough trajectory test there can be a minimal velocity deviation at the end of the trajectory due to how the robot interpolates motions. With a velocity tolerance of 0.0 there is a chance that we hit this tolerance. * Explicitly switch on controllers in test where they are needed (cherry picked from commit 1cd3ac5)
This was referenced Jul 2, 2025
urfeex
added a commit
that referenced
this pull request
Jul 2, 2025
…1444) * Set minimal velocity tolerance in passthrough trajectory test When running a quintic spline with the passthrough trajectory test there can be a minimal velocity deviation at the end of the trajectory due to how the robot interpolates motions. With a velocity tolerance of 0.0 there is a chance that we hit this tolerance. * Explicitly switch on controllers in test where they are needed (cherry picked from commit 1cd3ac5) Co-authored-by: Felix Exner <[email protected]>
urfeex
pushed a commit
that referenced
this pull request
Jul 2, 2025
…1445) * Set minimal velocity tolerance in passthrough trajectory test When running a quintic spline with the passthrough trajectory test there can be a minimal velocity deviation at the end of the trajectory due to how the robot interpolates motions. With a velocity tolerance of 0.0 there is a chance that we hit this tolerance. * Explicitly switch on controllers in test where they are needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a quintic spline with the passthrough trajectory test there can be a minimal velocity deviation at the end of the trajectory due to how the robot interpolates motions. With a velocity tolerance of 0.0 there is a chance that we hit this tolerance.