-
Notifications
You must be signed in to change notification settings - Fork 305
Fix flaky tests #1559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Fix flaky tests #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1559 +/- ##
==========================================
+ Coverage 3.59% 15.29% +11.70%
==========================================
Files 13 34 +21
Lines 947 3878 +2931
Branches 152 467 +315
==========================================
+ Hits 34 593 +559
- Misses 843 3268 +2425
+ Partials 70 17 -53
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a03e0a4 to
4f5ac53
Compare
Otherwise there is a race condition between sending the program ans starting the tests.
4f5ac53 to
3b8aaea
Compare
urmahp
approved these changes
Nov 10, 2025
mergify bot
pushed a commit
that referenced
this pull request
Nov 11, 2025
Wait for controller to become active Otherwise there is a race condition between sending the program ans starting the tests. (cherry picked from commit 32cf968)
mergify bot
pushed a commit
that referenced
this pull request
Nov 11, 2025
Wait for controller to become active Otherwise there is a race condition between sending the program ans starting the tests. (cherry picked from commit 32cf968)
This was referenced Nov 11, 2025
urfeex
pushed a commit
that referenced
this pull request
Nov 12, 2025
urfeex
pushed a commit
that referenced
this pull request
Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to address some of the flakiness in our integration tests.