Skip to content

Conversation

fmauch
Copy link
Contributor

@fmauch fmauch commented Oct 5, 2022

This PR aims at taking a step further in refactoring the description, as its current state is rather suboptimal. With this PR I strive for

  • Having a separated visual description from the control description
  • Having a single macro that users can include

I'll start this PR as a draft as I'd like to incorporate feedback from the community on how to structure things. In the long run I'd like to apply this restructuring also to the Humble and Rolling versions.

p0rys and others added 2 commits October 5, 2022 13:40
This way the kinematic structure will still be standalone while keeping
a single macro to include.
@fmauch
Copy link
Contributor Author

fmauch commented Oct 5, 2022

With that approach we've separated the robot's kinematics from the control xacro part while still providing a single macro to include. I'm not completely happy with this for the following reasons:

  • When creating their own descriptions users would either include the ur_macro.xacro part and instanciate xacro:ur_macro or include ur_kinematics_macro.xacro and instanciate xacro:ur_kinematics. This would however require to also parse the config files beforehand using the xacro:read_model_data macro. While that offers more flexibility, this also increases complexity by adding another macro layer.
  • The parsed config file data is used in both, the kinematics description and the control description. I am not sure whether we could call xacro:read_model_data inside both macros, that might be an easy way to mitigate this.
  • I don't really see the benefits, but that's probably either because I'm thinking about this the wrong way or that I don't have certain use cases in mind.

@fmauch fmauch added the Foxy label Oct 5, 2022
@destogl destogl self-requested a review October 6, 2022 09:59
@fmauch
Copy link
Contributor Author

fmauch commented May 9, 2023

I'm closing this, as this will not be implemented for foxy anymore. The discussion about this still goes on in UniversalRobots/Universal_Robots_ROS2_Description#56

@fmauch fmauch closed this May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants