Merged
Conversation
RobertWilbrandt
force-pushed
the
simplify_unit_tests
branch
from
e0340d7 to
fba56d2
Compare
This makes it easier to differentiate between ROS and test framework messages
4 tasks
Contributor
|
Maybe this would be a good point to add the URSim log to the artifacts similar to UniversalRobots/Universal_Robots_Client_Library@9b695e3 |
RobertWilbrandt
force-pushed
the
simplify_unit_tests
branch
2 times, most recently
from
ba3dc60 to
4e72386
Compare
Contributor
Author
|
That is not transferrable 100% - Because we start ursim from the test launch description the container is already dead when we want to copy out the logs. That is certainly solvable, but somewhat unrelated to restructuring the code. I'd prefer merging this now and adding that feature later on. |
fmauch
approved these changes
Oct 27, 2023
Contributor
fmauch
left a comment
fmauch
left a comment
There was a problem hiding this comment.
Thank you @RobertWilbrandt This will make future test extensions much easier.
mergify bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
* Remove duplication of launch description in tests * Move launch and interfacing boilerplate to common file * Move all test logs to python logging This makes it easier to differentiate between ROS and test framework messages * Move waiting for a controller to test_common * Move robot starting to dashboard interface * Remove unused request definition (cherry picked from commit b28a870) # Conflicts: # ur_robot_driver/test/dashboard_client.py # ur_robot_driver/test/robot_driver.py
mergify bot
pushed a commit
that referenced
this pull request
Oct 30, 2023
* Remove duplication of launch description in tests * Move launch and interfacing boilerplate to common file * Move all test logs to python logging This makes it easier to differentiate between ROS and test framework messages * Move waiting for a controller to test_common * Move robot starting to dashboard interface * Remove unused request definition (cherry picked from commit b28a870) # Conflicts: # ur_robot_driver/test/dashboard_client.py # ur_robot_driver/test/robot_driver.py # ur_robot_driver/test/urscript_interface.py
This was referenced Oct 30, 2023
fmauch
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Remove duplication of launch description in tests * Move launch and interfacing boilerplate to common file * Move all test logs to python logging This makes it easier to differentiate between ROS and test framework messages * Move waiting for a controller to test_common * Move robot starting to dashboard interface * Remove unused request definition (cherry picked from commit b28a870)
fmauch
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Remove duplication of launch description in tests * Move launch and interfacing boilerplate to common file * Move all test logs to python logging This makes it easier to differentiate between ROS and test framework messages * Move waiting for a controller to test_common * Move robot starting to dashboard interface * Remove unused request definition (cherry picked from commit b28a870)
fmauch
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Remove duplication of launch description in tests * Move launch and interfacing boilerplate to common file * Move all test logs to python logging This makes it easier to differentiate between ROS and test framework messages * Move waiting for a controller to test_common * Move robot starting to dashboard interface * Remove unused request definition (cherry picked from commit b28a870) Co-authored-by: RobertWilbrandt <wilbrandt@fzi.de>
fmauch
added a commit
that referenced
this pull request
Apr 17, 2024
* Simplify tests (#849) * Remove duplication of launch description in tests * Move launch and interfacing boilerplate to common file * Move all test logs to python logging This makes it easier to differentiate between ROS and test framework messages * Move waiting for a controller to test_common * Move robot starting to dashboard interface * Remove unused request definition (cherry picked from commit b28a870) * Add UR30 --------- Co-authored-by: RobertWilbrandt <wilbrandt@fzi.de> Co-authored-by: Felix Exner <exner@fzi.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our runtime tests have accumulated quite a bit of duplicated code for starting the driver and interfacing with ROS interfaces. Before adding more tests (MoveIt, mock_hardware, ...) this should get refactored and cleaned up.