Open
Conversation
ee880c2 to
512c24b
Compare
Contributor
Author
|
I could not get the servo node running correctly, which is why I would suggest taking fixing this out of this PR. Maybe we don't even put 7619306 in here? |
Contributor
|
I think we should rewrite the whole |
Contributor
|
Also I tested servo on both URSim and a real UR5, with same changes in 7619306. It worked well! |
This is a basic test that verifies that all Nodes come up correctly without crashing.
This makes it start but I couldn't get the robot moving.
The servo_node currently doesn't startup correctly until a plan is executed.
Also enabled CCache, since building MoveIt takes a very long time otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help us finding Moveit related errors like the one fixed in #906 earlier.
ToDo:
[ ] Fix servo_node startup (the test should fail for now, since that is actually broken)