fix!: license check should exit 0 when no dependencies found #1261
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe changes modify the license check command to treat the absence of hosted dependencies as a non-error condition. Logging behavior is adjusted from error logging to informational logging, and the exit code is updated from an error code to a success code. In addition, the corresponding tests are updated to reflect the new logging order and expected output, and minor formatting improvements in string concatenation are applied in another test file. Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant C as PackagesCheckLicensesCommand
participant L as Logger
participant E as ExitCode
U->>C: Run license check command
C->>C: Check for hosted dependencies
alt No hosted dependencies found
C->>L: Log info message
C->>E: Return success code
else Dependencies detected
C->>L: Log appropriate message
C->>E: Return corresponding exit code
end
Assessment against linked issues
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
⏰ Context from checks skipped due to timeout of 90000ms (15)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
felangel
force-pushed
the
fix/license-check-empty-dependencies
branch
from
f5f5d42 to
5acb9d2
Compare
Contributor
Author
|
FYI @wolfenrain @alestiago @erickzanardo e2e tests are failing because the templates need to be updated to fix the synthetic generation deprecation warning for l10n (https://docs.flutter.dev/release/breaking-changes/flutter-generate-i10n-source) |
Contributor
Yea that was already on my radar 🫡 |
wolfenrain
previously approved these changes
Apr 7, 2025
Contributor
|
Since #1286 the CI should now be all green. There were a few merge conflicts in two test files, I gave a first attempt at quickly resolving them where I could, I'll keep an eye on the pipeline. |
alestiago
reviewed
Jun 17, 2025
alestiago
changed the title
alestiago
approved these changes
Jun 17, 2025
matiasleyba
pushed a commit
to a-wallen/very_good_cli
that referenced
this pull request
Jul 17, 2025
…dOpenSource#1261) * fix: license check should exit 0 when no dependencies found * chore: remove ignore: no_adjacent_strings_in_list --------- Co-authored-by: Alejandro Santiago <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
Type of Change
Summary by CodeRabbit