-
Notifications
You must be signed in to change notification settings - Fork 54
v2 API - Add PWM and Servo Support #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… signal publish, fix pwmadd and pwmremove handler issues found during testing
Testing: Test Setup:
Integration Test(s)
|
Testing: Test Setup:
Unit Tests:
|
…riable timer width for ESP32x instead of hardcode
✅ Tested PWMWriteFrequency with an Adafruit FunHouse ESP32S2 |
brentru
commented
Apr 24, 2025
brentru
commented
Apr 24, 2025
brentru
commented
Apr 24, 2025
brentru
commented
Apr 24, 2025
brentru
commented
Apr 24, 2025
brentru
commented
Apr 24, 2025
brentru
commented
Apr 24, 2025
✅ Performed self review, pushing to tyeth for final review |
tyeth
reviewed
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for
pwm.proto
andservo.proto
messages, as part of the WipperSnapper_Proto v2 API refactor.PWM Support:
PWMController
class to manage PWM operationsServo Support:
ServoController
class to manage servo operationsResolves: #641