-
Notifications
You must be signed in to change notification settings - Fork 54
v2 API - Add PWM and Servo Support #733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 20 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
97be20a
Start! And added to hardware.cpp
brentru 184c5df
Doxy the hardware class
brentru 141753b
Implement Handler for PWMAdd Message
brentru ffd7a71
Tidy handler for PWMWriteDutycycle
brentru aadac2b
Tidy x2
brentru edadb31
Implement WriteFrequency message
brentru 31e5758
YAGNI - noTone() never implemented in v1 or called, remove from API
brentru 3304fb4
Full PWM implementation, sans writemulti..
brentru 3562104
Init. Servo
brentru a6d8755
Plumbing in app
brentru de50089
Implement - ServoAdd, ServoAdded API
brentru 8fc941e
Implement - ServoWrite, boundary checks around handling the servohard…
brentru 4cc35be
bugfixes
brentru e4ae80a
Implement - ServoRemove, fix bugs
brentru 59aba4e
Testing - Update NoFs.ino to work with Wokwi, add plumbing in app for…
brentru b32ecdf
Tests - behavioral, pwm
brentru 361f97d
Fix - Remove PWMWriteDutyCycle_Multi (Unused), fix logical bug in Wri…
brentru 7458980
Fix - ServoRemove Unit Test
brentru dac4af5
Fix - Controller writes the pulse width from the message upon Add, va…
brentru 7589b78
Clang
brentru 8c3dbdd
Address brent PR
brentru c1a3c4e
Address @tyeth PR review
brentru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.