Conversation
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Are we also linting commit messages and PR names? 🙂 |
Maybe we should 😅 -> https://github.com/marketplace/actions/pull-request-linter-action |
e3ce182 to
91718a8
Compare
406df67 to
4b9d601
Compare
4b9d601 to
cf6b2ac
Compare
adamkudrna
left a comment
There was a problem hiding this comment.
I think this is way too much opinionated. At least in this form. I mean, there are some nice touches and things I'd like to see checked, but I cannot give it a ✅ as a whole.
@literat (and everyone here) I jotted down some comments but I feel the discussion needs to be more structured. Can we maybe discuss individual rules first? What do you think is the best approach? (Long topics?)
cf6b2ac to
759cbd2
Compare
|
@adamkudrna Thanks for the review. Let's tweak it to our desires and needs. I think that the most problematic rule will be the Sources of stop words: https://github.com/sapegin/textlint-rule-stop-words?tab=readme-ov-file#sources CAn be disabled, rewritten or excluded: https://github.com/sapegin/textlint-rule-stop-words?tab=readme-ov-file#defaultwords-default-true The simple approach now can be just to disable |
|
Just for the note: the |
396b20e to
ac0dcf3
Compare
ac0dcf3 to
765fe59
Compare
765fe59 to
4758a2f
Compare
4758a2f to
32f3b81
Compare

Description
Linting text content of our documentation files. Only part of the packages are linted due to the changes.
Additional context
https://github.com/lmc-eu/code-quality-tools/blob/main/packages/textlint-rule-preset-lmc/index.js
Applied rules:
Most changes:
e.g.->for examplei.e.->that is'if you want to->toIssue reference
https://jira.almacareer.tech/browse/DS-1496