Skip to content

Remove forms-api task from review apps#1654

Merged
stephencdaly merged 2 commits intomainfrom
remove-api-from-review-apps
Sep 30, 2025
Merged

Remove forms-api task from review apps#1654
stephencdaly merged 2 commits intomainfrom
remove-api-from-review-apps

Conversation

@stephencdaly
Copy link
Contributor

@stephencdaly stephencdaly commented Sep 25, 2025

What problem does this pull request solve?

Trello card: https://trello.com/c/YWJAZ2A9/2499-remove-forms-api-from-review-apps

Forms-runner now makes requests to forms-admin rather than forms-api to get forms. Update the review apps so that the forms-api container is no longer created and forms-runner makes requests to forms-admin rather than forms-api.

We need to also set the ALLOWED_HOST_PATTERNS environment variable for the forms-admin container so that it allows requests from forms-runner to localhost:3000 to make requests to the forms-admin API without authorization being required.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Do the end to end tests need updating before these changes will pass?
  • Has all relevant documentation been updated?

@stephencdaly stephencdaly force-pushed the remove-api-from-review-apps branch from df2a47b to 02064db Compare September 25, 2025 09:54
@stephencdaly stephencdaly reopened this Sep 25, 2025
@stephencdaly stephencdaly force-pushed the remove-api-from-review-apps branch 2 times, most recently from 73f8f1e to 42c6b40 Compare September 25, 2025 11:47
@stephencdaly stephencdaly force-pushed the remove-api-from-review-apps branch 2 times, most recently from fd67a02 to 3fa7159 Compare September 25, 2025 16:42
@stephencdaly stephencdaly marked this pull request as draft September 25, 2025 16:45
@stephencdaly stephencdaly force-pushed the remove-api-from-review-apps branch 8 times, most recently from 6629c56 to bbbcc52 Compare September 29, 2025 15:59
@stephencdaly stephencdaly force-pushed the remove-api-from-review-apps branch from ee77a39 to 4950ac8 Compare September 30, 2025 08:38
Forms-runner now makes requests to forms-admin rather than forms-api
to get forms. Update the review apps so that the forms-api container
is no longer created and forms-runner makes requests to forms-admin
rather than forms-api.
Add localhost:3000 to the allowed hosts for forms-admin so that it
allows requests from forms-runner to the forms-admin API over the
local network without authorization being required.
@stephencdaly stephencdaly force-pushed the remove-api-from-review-apps branch from 4950ac8 to fba5023 Compare September 30, 2025 15:23
@stephencdaly stephencdaly marked this pull request as ready for review September 30, 2025 15:23
@sonarqubecloud
Copy link

@github-actions
Copy link
Contributor

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@stephencdaly stephencdaly merged commit 4746515 into main Sep 30, 2025
12 checks passed
@stephencdaly stephencdaly deleted the remove-api-from-review-apps branch September 30, 2025 16:11
lfdebrux added a commit that referenced this pull request Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants