Remove forms-api task from review apps#1654
Conversation
df2a47b to
02064db
Compare
73f8f1e to
42c6b40
Compare
fd67a02 to
3fa7159
Compare
6629c56 to
bbbcc52
Compare
ee77a39 to
4950ac8
Compare
Forms-runner now makes requests to forms-admin rather than forms-api to get forms. Update the review apps so that the forms-api container is no longer created and forms-runner makes requests to forms-admin rather than forms-api.
Add localhost:3000 to the allowed hosts for forms-admin so that it allows requests from forms-runner to the forms-admin API over the local network without authorization being required.
4950ac8 to
fba5023
Compare
|
|
🎉 A review copy of this PR has been deployed! It is made of up two components Important Not all of the functionality of forms-runner is present in review apps. You should use the full dev environment to test the functionality which is disabled here. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
This was missed from PR #1654.



What problem does this pull request solve?
Trello card: https://trello.com/c/YWJAZ2A9/2499-remove-forms-api-from-review-apps
Forms-runner now makes requests to forms-admin rather than forms-api to get forms. Update the review apps so that the forms-api container is no longer created and forms-runner makes requests to forms-admin rather than forms-api.
We need to also set the
ALLOWED_HOST_PATTERNSenvironment variable for the forms-admin container so that it allows requests from forms-runner to localhost:3000 to make requests to the forms-admin API without authorization being required.Things to consider when reviewing