build: clean up BUILD files and update dependencies #31407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angular-robot
bot
added
the
area: build & ci
alan-agius4
force-pushed
the
clean-up-bazel
branch
from
d2b8466 to
10df979
Compare
This commit cleans up various `BUILD.bazel` files by removing unused file globs from `RUNTIME_ASSETS` and test sources. Additionally, the conditional `include_npm` setting in `tests/legacy-cli/e2e.bzl` has been removed.
alan-agius4
force-pushed
the
clean-up-bazel
branch
from
10df979 to
8a010e1
Compare
alan-agius4
commented
Oct 7, 2025
| node_toolchain = toolchain, | ||
| include_npm = select({ | ||
| # For Windows testing mode, we use the real global NPM as otherwise this | ||
| # will be a lot of files that need to be brought from WSL to the host FS. |
There was a problem hiding this comment.
WSL is no longer used to compile the files.
There was a problem hiding this comment.
To build we use native Linux and to test we use native Windows. More context: #31038
alan-agius4
added
the
target: major
alan-agius4
added
target: patch
devversion
approved these changes
Oct 7, 2025
| node_toolchain = toolchain, | ||
| include_npm = select({ | ||
| # For Windows testing mode, we use the real global NPM as otherwise this | ||
| # will be a lot of files that need to be brought from WSL to the host FS. |
alan-agius4
added
action: merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit cleans up various
BUILD.bazelfiles by removing empty file globs fromRUNTIME_ASSETSand test sources.Additionally, the conditional
include_npmsetting intests/legacy-cli/e2e.bzlhas been removed.