Skip to content

build: clean up BUILD files and update dependencies #31407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 7, 2025
Merged

build: clean up BUILD files and update dependencies #31407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,6 @@ multiple_version_override(
],
)

bazel_dep(name = "rules_python", version = "1.5.3")
single_version_override(
module_name = "rules_python",
version = "1.5.3",
)

bazel_dep(name = "aspect_bazel_lib", version = "2.21.2")
bazel_dep(name = "bazel_skylib", version = "1.8.2")
bazel_dep(name = "aspect_rules_esbuild", version = "0.22.1")
Expand Down
2,872 changes: 2,849 additions & 23 deletions MODULE.bazel.lock
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions packages/angular/build/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,6 @@ RUNTIME_ASSETS = glob(
include = [
"src/**/schema.json",
"src/**/*.js",
"src/**/*.mjs",
"src/**/*.html",
],
) + [
"builders.json",
Expand Down
7 changes: 1 addition & 6 deletions packages/angular/create/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,7 @@ load("//tools:defaults.bzl", "npm_package", "ts_project")

licenses(["notice"])

RUNTIME_ASSETS = glob(
include = [
"src/*.js",
"src/*.mjs",
],
) + [
RUNTIME_ASSETS = [
"package.json",
]

Expand Down
2 changes: 0 additions & 2 deletions packages/angular/pwa/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@ npm_link_all_packages()

RUNTIME_ASSETS = glob(
include = [
"pwa/*.js",
"pwa/*.mjs",
"pwa/files/**/*",
],
) + [
Expand Down
2 changes: 0 additions & 2 deletions packages/angular_devkit/schematics/tools/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ ts_project(
include = ["**/*.ts"],
exclude = [
"**/*_spec.ts",
"test/**/*.ts",
],
),
data = ["package.json"],
Expand All @@ -35,7 +34,6 @@ ts_project(
srcs = glob(
include = [
"**/*_spec.ts",
"test/**/*.ts",
],
),
deps = [
Expand Down
2 changes: 0 additions & 2 deletions packages/ngtools/webpack/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ ts_project(
],
exclude = [
"src/**/*_spec.ts",
"src/**/*_spec_helpers.ts",
],
) + [
"index.ts",
Expand All @@ -43,7 +42,6 @@ ts_project(
srcs = glob(
include = [
"src/**/*_spec.ts",
"src/**/*_spec_helpers.ts",
],
),
deps = [
Expand Down
1 change: 0 additions & 1 deletion packages/schematics/angular/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ RUNTIME_ASSETS = [
include = [
"*/schema.json",
"*/files/**/*",
"*/other-files/**/*",
"*/implements-files/**/*",
"*/type-files/**/*",
"*/functional-files/**/*",
Expand Down
7 changes: 1 addition & 6 deletions tests/legacy-cli/e2e.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,7 @@ def _e2e_tests(name, runner, toolchain, **kwargs):
tags = tags,
toolchains = toolchains,
node_toolchain = toolchain,
include_npm = select({
# For Windows testing mode, we use the real global NPM as otherwise this
# will be a lot of files that need to be brought from WSL to the host FS.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WSL is no longer used to compile the files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you mean native Windows?

Copy link
Collaborator Author

@alan-agius4 alan-agius4 Oct 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To build we use native Linux and to test we use native Windows. More context: #31038

"@platforms//os:windows": False,
"//conditions:default": True,
}),
include_npm = False,
**kwargs
)

Expand Down