Skip to content

fix(material/sort): If there is no direction, setting active as empty #22029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(material/sort): If there is no direction, setting active as empty #22029

wants to merge 1 commit into from

Conversation

Suresh918
Copy link
Contributor

@Suresh918 Suresh918 commented Feb 26, 2021 •
edited
Loading

Fixes #15169

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Feb 26, 2021
@Suresh918 Suresh918 mentioned this pull request Feb 26, 2021
Closed
@andrewseguin andrewseguin added action: merge The PR is ready for merge by the caretaker P2 The issue is important to a large percentage of users, with a workaround labels Mar 5, 2021
andrewseguin
andrewseguin previously approved these changes Mar 5, 2021
View reviewed changes
@annieyw annieyw added the target: patch This PR is targeted for the next patch release label Mar 7, 2021
@andrewseguin andrewseguin removed the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 28, 2021
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 29, 2021
@andrewseguin
Copy link
Contributor

@Suresh918 Can you rebase this for us?

@andrewseguin andrewseguin added the needs: clarification The issue does not contain enough information for the team to determine if it is a real bug label Mar 24, 2022
@mmalerba mmalerba force-pushed the sort-active-default-value branch from 156f72d to 366d16f Compare November 8, 2022 22:10
@mmalerba mmalerba removed needs rebase needs: clarification The issue does not contain enough information for the team to determine if it is a real bug labels Nov 8, 2022
@mmalerba mmalerba force-pushed the sort-active-default-value branch from 366d16f to a22264a Compare November 8, 2022 22:14
@mmalerba mmalerba assigned mmalerba and unassigned mmalerba Nov 12, 2024
@mmalerba mmalerba self-requested a review November 12, 2024 20:07
@mmalerba mmalerba closed this Nov 12, 2024
@mmalerba mmalerba reopened this Nov 12, 2024
@mmalerba mmalerba requested a review from a team as a code owner November 12, 2024 20:07
@mmalerba mmalerba requested review from amysorto and crisbeto and removed request for a team November 12, 2024 20:07
@andrewseguin andrewseguin self-assigned this Dec 11, 2024
@andrewseguin
Copy link
Contributor

Closing since this breaks many internal applications which have built assumptions around this behavior.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mmalerba mmalerba mmalerba approved these changes

@andrewseguin andrewseguin andrewseguin left review comments

@crisbeto crisbeto Awaiting requested review from crisbeto crisbeto is a code owner automatically assigned from angular/components-googlers

@amysorto amysorto Awaiting requested review from amysorto amysorto is a code owner automatically assigned from angular/components-googlers

Assignees

@andrewseguin andrewseguin

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Sort] If there is no direction, active should not be populated with a sortable ID

5 participants

@Suresh918 @andrewseguin @mmalerba @googlebot @annieyw