-
Notifications
You must be signed in to change notification settings - Fork 201
FIX: Bug located in primitives circuit module #6775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (75.00%) is below the target coverage (85.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6775 +/- ##
=======================================
Coverage 83.49% 83.49%
=======================================
Files 245 245
Lines 77511 77511
=======================================
+ Hits 64714 64718 +4
+ Misses 12797 12793 -4 🚀 New features to boost your workflow:
|
|
Hi @ramin4667 , Do you have an issue linked to this PR? if yes please link it. Thanks, KR, Giulia |
Hi @gmalinve, The PR is updated with a link to an issue. |
|
Hi @ramin4667, yes. I linked it before. |
…thub.com/ansys/pyaedt into Bug_located_in_primitives_circuit_module
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that the other occurrences of setting id have been updated and the tests are passing still.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ramin4667 There is at least one change needed for the tests. I saw a failure caused by the test looking for an int where the type is now a string. Please review the failing tests.
@myoung301 Tests are updated and passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed changes and looks good.
Description
**This PR fixes the error due to non-digit circuit element IDs. **
Issue linked
**The post-processing call for the simulated circuit of this example https://examples.aedt.docs.pyansys.com/version/dev/examples/high_frequency/radiofrequency_mmwave/lumped_element.html raises an error. **
Checklist