Skip to content

Conversation

@JinwooHwang
Copy link
Contributor

@JinwooHwang JinwooHwang commented Aug 26, 2025

Summary

  • Refreshes exclusion list used by code analysis to suppress false positives on internal, generated, legacy, or intentionally unstable types.

Key Adjustments

  • Anonymous Jackson Module instance in PreventReserializationModule was created to tweak (de)serialization behavior (prevents unintended reserialization). Synthetic, name and shape may change with Jackson or refactors.
  • Anonymous Jackson Module in TypeSerializationEnforcerModule was instantiated to enforce strict typing during query result JSON rendering.

Impact

  • No runtime code changes.
  • Cleaner, more signal‑rich API compatibility reports.
  • Low maintenance overhead for future internal refactors.

Updated File

  • excludedClasses.txt

Rationale

Excluded classes:

  • Are internal implementation details subject to change without API commitment.
  • Represent enums / inner classes whose binary changes are low‑risk or expected.
  • Are test or debug hooks (e.g., GitTestHook, TestHook spots) not part of supported surface.
  • Reduce churn and false alerts in signature / compatibility verification tooling.

Follow-up

  • Periodically review for additional transient JSON helper classes if tooling starts flagging them.

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?

  • Has your PR been rebased against the latest commit within the target branch (typically develop)?

  • Is your initial contribution a single, squashed commit?

  • Does gradlew build run cleanly?

  • Have you written or updated unit tests to verify your changes?

  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?

@JinwooHwang JinwooHwang merged commit 9d736a9 into apache:develop Aug 26, 2025
15 of 17 checks passed
@JinwooHwang JinwooHwang deleted the AbstractJSONFormatter branch August 26, 2025 18:08
@raboof raboof changed the title Update Code Analysis with Jackson modules GEODE-10458: Update Code Analysis with Jackson modules Aug 27, 2025
JinwooHwang added a commit that referenced this pull request Sep 3, 2025
* AbstractJSONFormatter

(cherry picked from commit 9d736a9)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant