refactor: remove unused arrow_c_data_internal files #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nullccxsy
commented
Aug 31, 2025
nullccxsy
commented
- Replace individual child array management with parent array StartAppending/FinishElement pattern for cleaner code.
- Replace individual child array management with parent array StartAppending/FinishElement pattern for cleaner code.
HeartLinked
approved these changes
Sep 1, 2025
Member
|
This file should be eventually deleted. Could you help do this? |
- Delete unused nanoarrow example code and test files - Clean up dependencies and remove obsolete test cases
nullccxsy
changed the title
Fokko
approved these changes
Sep 1, 2025
Contributor
Fokko
left a comment
Fokko
left a comment
There was a problem hiding this comment.
Less is more 🙌 Thanks @nullccxsy for working on this, and thanks @wgtmac and @HeartLinked for the review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.