Skip to content

refactor: remove unused arrow_c_data_internal files #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 1, 2025
Merged

refactor: remove unused arrow_c_data_internal files #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4ab42c4
fix: simplify Arrow array building using parent array operations
Aug 31, 2025
43c8560
refactor: remove unused arrow_c_data_internal files
Sep 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/iceberg/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
set(ICEBERG_INCLUDES "$<BUILD_INTERFACE:${PROJECT_BINARY_DIR}/src>"
"$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}/src>")
set(ICEBERG_SOURCES
arrow_c_data_internal.cc
catalog/in_memory_catalog.cc
expression/expression.cc
expression/literal.cc
Expand Down
85 changes: 0 additions & 85 deletions src/iceberg/arrow_c_data_internal.cc
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions src/iceberg/arrow_c_data_internal.h
View file
Open in desktop

This file was deleted.

34 changes: 0 additions & 34 deletions test/arrow_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,46 +28,12 @@
#include <arrow/util/key_value_metadata.h>
#include <gtest/gtest.h>

#include "iceberg/arrow_c_data_internal.h"
#include "iceberg/schema.h"
#include "iceberg/schema_internal.h"
#include "matchers.h"

namespace iceberg {

TEST(ArrowCDataTest, CheckArrowSchemaAndArrayByNanoarrow) {
auto [schema, array] = internal::CreateExampleArrowSchemaAndArrayByNanoarrow();

auto arrow_schema = ::arrow::ImportSchema(&schema).ValueOrDie();
EXPECT_EQ(arrow_schema->num_fields(), 2);

auto id_field = arrow_schema->field(0);
EXPECT_EQ(id_field->name(), "id");
EXPECT_EQ(id_field->type()->id(), ::arrow::Type::INT64);
EXPECT_FALSE(id_field->nullable());

auto name_field = arrow_schema->field(1);
EXPECT_EQ(name_field->name(), "name");
EXPECT_EQ(name_field->type()->id(), ::arrow::Type::STRING);
EXPECT_TRUE(name_field->nullable());

auto arrow_record_batch = ::arrow::ImportRecordBatch(&array, arrow_schema).ValueOrDie();
EXPECT_EQ(arrow_record_batch->num_rows(), 3);
EXPECT_EQ(arrow_record_batch->num_columns(), 2);

auto id_column = arrow_record_batch->column(0);
EXPECT_EQ(id_column->type()->id(), ::arrow::Type::INT64);
EXPECT_EQ(id_column->GetScalar(0).ValueOrDie()->ToString(), "1");
EXPECT_EQ(id_column->GetScalar(1).ValueOrDie()->ToString(), "2");
EXPECT_EQ(id_column->GetScalar(2).ValueOrDie()->ToString(), "3");

auto name_column = arrow_record_batch->column(1);
EXPECT_EQ(name_column->type()->id(), ::arrow::Type::STRING);
EXPECT_EQ(name_column->GetScalar(0).ValueOrDie()->ToString(), "a");
EXPECT_EQ(name_column->GetScalar(1).ValueOrDie()->ToString(), "b");
EXPECT_EQ(name_column->GetScalar(2).ValueOrDie()->ToString(), "c");
}

struct ToArrowSchemaParam {
std::shared_ptr<Type> iceberg_type;
bool optional = true;
Expand Down
Loading