Alleviate connection leaks caused by Seata Client throwing exceptions#34463
Merged
terrymanu merged 1 commit intoapache:masterfrom Jan 24, 2025
Merged
Alleviate connection leaks caused by Seata Client throwing exceptions#34463terrymanu merged 1 commit intoapache:masterfrom
terrymanu merged 1 commit intoapache:masterfrom
Conversation
e407dce to
4edcdb9
Compare
4edcdb9 to
3695c21
Compare
terrymanu
approved these changes
Jan 24, 2025
This was referenced Jan 24, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33831.
Changes proposed in this pull request:
2.2.0. The related bug was first reproduced in the CI environment of Add GraalVM Reachability Metadata and corresponding nativeTest for Firebird #34307 (review) .ShardingSphere DriverDatabaseConnectionManageris superimposed, resulting in a connection leak bug in other unit tests of the same module.Awaitility.await().pollDelay(5L, TimeUnit.SECONDS).until(() -> true)destroys the robustness of the unit test.org.apache.shardingsphere.test.natived.jdbc.transactions.base.SeataTest,org.apache.shardingsphere.test.natived.proxy.transactions.base.SeataTest,Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.