[SPARK-53376] Run Swift build first before running test
#222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
approved these changes
Aug 25, 2025
|
Thank you, @viirya . Although there still exists to care, this will help the stabilization. I'm working on it. |
|
Merged to main. |
|
Late LGTM. |
dongjoon-hyun
added a commit
that referenced
this pull request
Aug 28, 2025
### What changes were proposed in this pull request? This PR aims to make `Build` step to verify test compilation too. ### Why are the changes needed? Like Apache Spark main repo, SPARK-53376 added the `Build` step before running the actual test. - #222 However, it turns out that the test code building is not verified correctly. So, this PR aims to use the following workaround to verify test code fully without running any test. ```yaml - run: swift build -c release + run: swift test --filter NOTHING -c release ``` In addition, this reduces the total runtime of CIs like the following example. - BEFORE: 13m 43s - https://github.com/apache/spark-connect-swift/actions/runs/17244668737/job/48932508796 - AFTER: 11m 35s - https://github.com/apache/spark-connect-swift/actions/runs/17252163531/job/48956652819?pr=225 ### Does this PR introduce _any_ user-facing change? No. This is a test infra change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #225 from dongjoon-hyun/BUILD_TEST_CODE. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to build
Swiftcode first before runningtest.Why are the changes needed?
Like
Apache Sparkmain repository, we had better stabilize the CIs by isolating any compilation failures first before running the tests.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs.
Was this patch authored or co-authored using generative AI tooling?
No.