[SPARK-52201] Revisit PMD annotations
#210
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
commented
May 17, 2025
| import org.apache.spark.metrics.sink.Sink; | ||
|
|
||
| @SuppressWarnings("PMD") | ||
| @SuppressWarnings("PMD.UnusedPrivateField") |
Member
Author
There was a problem hiding this comment.
There is only one warning in this file.
dongjoon-hyun
commented
May 17, 2025
|
|
||
| @EnableKubernetesMockClient(crud = true) | ||
| @TestMethodOrder(MethodOrderer.OrderAnnotation.class) | ||
| @SuppressWarnings("PMD") |
Member
Author
There was a problem hiding this comment.
We don't need this.
dongjoon-hyun
commented
May 17, 2025
| import org.apache.spark.k8s.operator.utils.SparkAppStatusRecorder; | ||
|
|
||
| @EnableKubernetesMockClient(crud = true) | ||
| @SuppressWarnings("PMD") |
Member
Author
There was a problem hiding this comment.
This file is added newly, but we don't need this.
dongjoon-hyun
force-pushed
the
SPARK-52201
branch
from
798fdd2 to
909fefc
Compare
dongjoon-hyun
commented
May 17, 2025
| import org.apache.spark.k8s.operator.metrics.healthcheck.SentinelManager; | ||
|
|
||
| @SuppressWarnings("PMD.JUnitTestsShouldIncludeAssert") | ||
| @SuppressWarnings("PMD.UnitTestShouldIncludeAssert") |
Member
Author
There was a problem hiding this comment.
This is renamed at PMD 7.
dongjoon-hyun
commented
May 17, 2025
| import org.apache.spark.k8s.operator.utils.ProbeUtil; | ||
|
|
||
| @SuppressWarnings("PMD.JUnitTestsShouldIncludeAssert") | ||
| @SuppressWarnings("PMD.UnitTestShouldIncludeAssert") |
Member
Author
There was a problem hiding this comment.
This is renamed at PMD 7.
viirya
approved these changes
May 17, 2025
Member
Author
|
Thank you, @viirya . Merged to main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to revisit
PMDannotations.Why are the changes needed?
We can remove or reduce the scope.
BEFORE
AFTER
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual review.
Was this patch authored or co-authored using generative AI tooling?
No.