Skip to content

[SPARK-53795][CONNECT] Remove unused parameters in LiteralValueProtoConverter #52512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[SPARK-53795][CONNECT] Remove unused parameters in LiteralValueProtoConverter #52512

wants to merge 1 commit into from
+6 −10

Conversation

heyihong
Copy link
Contributor

@heyihong heyihong commented Oct 3, 2025 •
edited
Loading

What changes were proposed in this pull request?

This PR removes unused parameters from the LiteralValueProtoConverter:

  1. Removed containsNull parameter from the arrayBuilder method signature and its usage in pattern matching for ArrayType
  2. Removed valueContainsNull parameter from the mapBuilder method signature and its usage in pattern matching for MapType

Why are the changes needed?

The containsNull and valueContainsNull parameters were not being used within the arrayBuilder and mapBuilder methods.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests

Was this patch authored or co-authored using generative AI tooling?

Generated-by: Cursor 1.7.28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CONNECT SQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@heyihong