Skip to content

Conversation

@sloretz
Copy link
Contributor

@sloretz sloretz commented Mar 25, 2025

Description

This PR fixes two issues to get autoware_trajectory building with Rolling

Related links

Parent Issue:

  • Link

How was this PR tested?

Ubuntu Noble ROS Rolling with ament/ament_cmake#571

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@sloretz sloretz requested review from a team, soblin, takayuki5168 and yhisaki as code owners March 25, 2025 23:27
@github-actions
Copy link

github-actions bot commented Mar 25, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@sloretz sloretz changed the title Fix linking issue with pybind11, and use non-deprecated tf2 headers fix: fix linking issue with pybind11, and use non-deprecated tf2 headers Mar 26, 2025
@wep21 wep21 added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 26, 2025
@codecov
Copy link

codecov bot commented Mar 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 24.69%. Comparing base (4cb18f5) to head (c37097d).
Report is 127 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #316       +/-   ##
===========================================
- Coverage   78.75%   24.69%   -54.06%     
===========================================
  Files          11       95       +84     
  Lines         193     4288     +4095     
  Branches       73     1132     +1059     
===========================================
+ Hits          152     1059      +907     
- Misses         11     3095     +3084     
- Partials       30      134      +104     
Flag Coverage Δ
differential 24.69% <ø> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sloretz sloretz changed the title fix: fix linking issue with pybind11, and use non-deprecated tf2 headers fix(autoware_trajectory): fix linking issue with pybind11, and use non-deprecated tf2 headers Mar 26, 2025
Signed-off-by: Shane Loretz <[email protected]>
Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@youtalk youtalk enabled auto-merge (squash) March 27, 2025 12:25
@youtalk youtalk merged commit 8d07622 into autowarefoundation:main Mar 27, 2025
24 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants