-
Notifications
You must be signed in to change notification settings - Fork 116
fix(autoware_trajectory): fix linking issue with pybind11, and use non-deprecated tf2 headers #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(autoware_trajectory): fix linking issue with pybind11, and use non-deprecated tf2 headers #316
Conversation
Signed-off-by: Shane Loretz <[email protected]>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #316 +/- ##
===========================================
- Coverage 78.75% 24.69% -54.06%
===========================================
Files 11 95 +84
Lines 193 4288 +4095
Branches 73 1132 +1059
===========================================
+ Hits 152 1059 +907
- Misses 11 3095 +3084
- Partials 30 134 +104
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
Signed-off-by: Shane Loretz <[email protected]>
youtalk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
This PR fixes two issues to get autoware_trajectory building with Rolling
-Werrorcauses the build to fail after Deprecate C Headers ros2/geometry2#720Related links
Parent Issue:
How was this PR tested?
Ubuntu Noble ROS Rolling with ament/ament_cmake#571
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.