build(autoware_trajectory): add missing include#853
Merged
sasakisasaki merged 2 commits intoautowarefoundation:mainfrom Mar 3, 2026
Merged
build(autoware_trajectory): add missing include#853sasakisasaki merged 2 commits intoautowarefoundation:mainfrom
sasakisasaki merged 2 commits intoautowarefoundation:mainfrom
Conversation
std::clamp() added in autowarefoundation#791 needs to include <algorithm>. Without it, GCC 14 complains with "error: 'clamp' is not a member of 'std'". Signed-off-by: Michal Sojka <michal.sojka@cvut.cz>
wentasah
requested review from
a team,
PanConChicharron,
kosuke55,
mkquda,
sasakisasaki,
soblin,
takayuki5168 and
yhisaki
as code owners
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
soblin
approved these changes
Feb 25, 2026
soblin
added
the
run:build-and-test-differential
soblin
changed the title
sasakisasaki
approved these changes
Mar 3, 2026
Contributor
sasakisasaki
left a comment
sasakisasaki
left a comment
There was a problem hiding this comment.
Thank you for your contribution! Reviewed, and I agree with merging this PR 👍
I believe this CI build will pass.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
==========================================
+ Coverage 50.47% 50.53% +0.05%
==========================================
Files 364 348 -16
Lines 22869 22427 -442
Branches 10170 9958 -212
==========================================
- Hits 11544 11333 -211
+ Misses 10215 10011 -204
+ Partials 1110 1083 -27
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
std::clamp()added in #791 needs#include <algorithm>. Without it, GCC 14 complains witherror: 'clamp' is not a member of 'std'.Related links
Parent Issue:
How was this PR tested?
Compile-tested only.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.