fix(lanelet2_utils): add invalid bound size handler in combine_lanelets_shape#878
Draft
sarun-hub wants to merge 1 commit intoautowarefoundation:mainfrom
Draft
fix(lanelet2_utils): add invalid bound size handler in combine_lanelets_shape#878sarun-hub wants to merge 1 commit intoautowarefoundation:mainfrom
sarun-hub wants to merge 1 commit intoautowarefoundation:mainfrom
Conversation
Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #878 +/- ##
==========================================
- Coverage 50.35% 50.35% -0.01%
==========================================
Files 358 358
Lines 22780 22784 +4
Branches 10120 10122 +2
==========================================
Hits 11472 11472
- Misses 10203 10205 +2
- Partials 1105 1107 +2
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
combine_lanelets_shapeis ported fromautoware_lanelet2_extension/utilitiestoautoware_lanelet2_utilsin #842.At that PR, we assumed that the lanelet Bound and centerline will contain at least 2 points as definition, thus, we access the optional value that create lanelet and linestring without less than 1 point handler.
But in some cases, there is only one point in bound, that cause the error in the system. (https://evaluation.tier4.jp/evaluation/reports/567aefe2-5399-5033-926f-087787e3501a/tests/7f7a4f81-66bc-51ba-89ac-18e24310a694/ff7bfb3b-5b56-5564-9763-dcea5f51b4e3/eedc4fbf-71db-5cdd-aa12-f4e6f8a32d26?failure_cause_labels=ConditionFailure%3ASimulationTimeCondition%2CConditionFailure%3AStandStillCondition%2CROSProcessDied%2CSimulationFailure&project_id=autoware_dev)
This PR adds the handler for that case (invalid bound size handler).
Related links
Parent Issue:
How was this PR tested?
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.