Skip to content

fix(lanelet2_utils): add invalid bound size handler in combine_lanelets_shape#878

Draft
sarun-hub wants to merge 1 commit intoautowarefoundation:mainfrom
sarun-hub:fix/combine_lanelets_shape
Draft

fix(lanelet2_utils): add invalid bound size handler in combine_lanelets_shape#878
sarun-hub wants to merge 1 commit intoautowarefoundation:mainfrom
sarun-hub:fix/combine_lanelets_shape

Conversation

@sarun-hub
Copy link
Contributor

Description

combine_lanelets_shape is ported from autoware_lanelet2_extension/utilities to autoware_lanelet2_utils in #842.
At that PR, we assumed that the lanelet Bound and centerline will contain at least 2 points as definition, thus, we access the optional value that create lanelet and linestring without less than 1 point handler.

But in some cases, there is only one point in bound, that cause the error in the system. (https://evaluation.tier4.jp/evaluation/reports/567aefe2-5399-5033-926f-087787e3501a/tests/7f7a4f81-66bc-51ba-89ac-18e24310a694/ff7bfb3b-5b56-5564-9763-dcea5f51b4e3/eedc4fbf-71db-5cdd-aa12-f4e6f8a32d26?failure_cause_labels=ConditionFailure%3ASimulationTimeCondition%2CConditionFailure%3AStandStillCondition%2CROSProcessDied%2CSimulationFailure&project_id=autoware_dev)
This PR adds the handler for that case (invalid bound size handler).

Related links

Parent Issue:

  • Link

How was this PR tested?

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Sarun Mukdapitak <sarun.mukda@gmail.com>
@sarun-hub sarun-hub self-assigned this Mar 3, 2026
@sarun-hub sarun-hub added the run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Mar 3, 2026
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@codecov
Copy link

codecov bot commented Mar 3, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.35%. Comparing base (d091381) to head (6297e1c).

Files with missing lines Patch % Lines
common/autoware_lanelet2_utils/src/geometry.cpp 0.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #878      +/-   ##
==========================================
- Coverage   50.35%   50.35%   -0.01%     
==========================================
  Files         358      358              
  Lines       22780    22784       +4     
  Branches    10120    10122       +2     
==========================================
  Hits        11472    11472              
- Misses      10203    10205       +2     
- Partials     1105     1107       +2     
Flag Coverage Δ *Carryforward flag
daily-humble 50.73% <ø> (ø) Carriedforward from d091381
daily-jazzy 50.21% <ø> (ø) Carriedforward from d091381
differential-humble 37.64% <0.00%> (?)
differential-jazzy 37.58% <0.00%> (?)
total 50.38% <ø> (ø) Carriedforward from d091381
total-humble 50.73% <ø> (ø) Carriedforward from d091381
total-jazzy 50.21% <ø> (ø) Carriedforward from d091381

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run:build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant