refactor(core/types): separate coreth and upstream identifiers #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARR4N
commented
Mar 13, 2025
ARR4N
commented
Mar 13, 2025
qdm12
approved these changes
Mar 14, 2025
ceyonur
approved these changes
Mar 14, 2025
ARR4N
added a commit
that referenced
this pull request
Mar 14, 2025
## Why this should be merged Complete the transition of `core/types` to upstream code. ## How this works Note that #872 results in _all_ upstream types / vars / consts being in the `imports.go` file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths. 1. Globally change all imports from `coreth/core/types` to `libevm/core/types`; 2. Rename all `coreth/core/types` imports to `customtypes` for ease of review here; 3. Dot import `libevm/core/types` in tests only to avoid hundreds of noisy changes.
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 19, 2025
Reduces overlap between subnet-evm and upstream files: - Types and variables that are identical to `libevm` are moved to `imports.go`. - Files that include only `subnet-evm` have the `_ext.go` suffix added. See original PR ava-labs/coreth#872
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 19, 2025
Reduces overlap between subnet-evm and upstream files: - Types and variables that are identical to `libevm` are moved to `imports.go`. - Files that include only `subnet-evm` have the `_ext.go` suffix added. See original PR ava-labs/coreth#872
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 21, 2025
Reduces overlap between subnet-evm and upstream files: - Types and variables that are identical to `libevm` are moved to `imports.go`. - Files that include only `subnet-evm` have the `_ext.go` suffix added. See original PR ava-labs/coreth#872
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 21, 2025
Reduces overlap between subnet-evm and upstream files: - Types and variables that are identical to `libevm` are moved to `imports.go`. - Files that include only `subnet-evm` have the `_ext.go` suffix added. See original PR ava-labs/coreth#872
qdm12
pushed a commit
that referenced
this pull request
Mar 24, 2025
## Why this should be merged Reduces overlap between `coreth` and upstream files. ## How this works 1. Types and variables that are identical to `libevm` are moved to `imports.go`. 2. Files that include only `coreth` have the `_ext.go` suffix added. ## How this was tested This is a no-op with respect to logic already undergoing bootstrap testing. The existing CI and a pre-release canary are therefore sufficient.
qdm12
pushed a commit
that referenced
this pull request
Mar 24, 2025
## Why this should be merged Complete the transition of `core/types` to upstream code. ## How this works Note that #872 results in _all_ upstream types / vars / consts being in the `imports.go` file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths. 1. Globally change all imports from `coreth/core/types` to `libevm/core/types`; 2. Rename all `coreth/core/types` imports to `customtypes` for ease of review here; 3. Dot import `libevm/core/types` in tests only to avoid hundreds of noisy changes.
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 24, 2025
Reduces overlap between subnet-evm and upstream files: - Types and variables that are identical to `libevm` are moved to `imports.go`. - Files that include only `subnet-evm` have the `_ext.go` suffix added. See original PR ava-labs/coreth#872
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 24, 2025
Reduces overlap between subnet-evm and upstream files: - Types and variables that are identical to `libevm` are moved to `imports.go`. - Files that include only `subnet-evm` have the `_ext.go` suffix added. See original PR ava-labs/coreth#872
qdm12
pushed a commit
that referenced
this pull request
Mar 24, 2025
## Why this should be merged Reduces overlap between `coreth` and upstream files. ## How this works 1. Types and variables that are identical to `libevm` are moved to `imports.go`. 2. Files that include only `coreth` have the `_ext.go` suffix added. ## How this was tested This is a no-op with respect to logic already undergoing bootstrap testing. The existing CI and a pre-release canary are therefore sufficient.
qdm12
pushed a commit
that referenced
this pull request
Mar 24, 2025
## Why this should be merged Complete the transition of `core/types` to upstream code. ## How this works Note that #872 results in _all_ upstream types / vars / consts being in the `imports.go` file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths. 1. Globally change all imports from `coreth/core/types` to `libevm/core/types`; 2. Rename all `coreth/core/types` imports to `customtypes` for ease of review here; 3. Dot import `libevm/core/types` in tests only to avoid hundreds of noisy changes.
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 24, 2025
Reduces overlap between subnet-evm and upstream files: - Types and variables that are identical to `libevm` are moved to `imports.go`. - Files that include only `subnet-evm` have the `_ext.go` suffix added. See original PR ava-labs/coreth#872
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Mar 28, 2025
Reduces overlap between subnet-evm and upstream files: - Types and variables that are identical to `libevm` are moved to `imports.go`. - Files that include only `subnet-evm` have the `_ext.go` suffix added. See original PR ava-labs/coreth#872
qdm12
added a commit
to ava-labs/subnet-evm
that referenced
this pull request
Apr 1, 2025
Reduces overlap between subnet-evm and upstream files: - Types and variables that are identical to `libevm` are moved to `imports.go`. - Files that include only `subnet-evm` have the `_ext.go` suffix added. See original PR ava-labs/coreth#872
node-druidx56y
added a commit
to node-druidx56y/subnet-evm
that referenced
this pull request
Sep 28, 2025
Reduces overlap between subnet-evm and upstream files: - Types and variables that are identical to `libevm` are moved to `imports.go`. - Files that include only `subnet-evm` have the `_ext.go` suffix added. See original PR ava-labs/coreth#872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
The broken CI will be fixed by fjl/gencodec#28. I'll update to that version once merged, but review of this PR can begin in the interim.Why this should be merged
Reduces overlap between
corethand upstream files.How this works
libevmare moved toimports.go.corethhave the_ext.gosuffix added.Note
This is part of a chain of PRs, followed by #875. The chain is split so that each one is "obviously" correct. I will not consider any review changes that deviate from this simplicity—if this is an issue, please explain why and add a "Do not merge" label.
How this was tested
This is a no-op with respect to logic already undergoing bootstrap testing. The existing CI and a pre-release canary are therefore sufficient.
Need to be documented?
No
Need to update RELEASES.md?
No