Skip to content

refactor: use upstream core/types #875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: chore(all): libevm phase 2.5
merged 24 commits into from
Mar 14, 2025
Merged

refactor: use upstream core/types #875

merged 24 commits into from
Mar 14, 2025

Conversation

@ARR4N
Copy link
Collaborator

@ARR4N ARR4N commented Mar 14, 2025 •
edited
Loading

Why this should be merged

Complete the transition of core/types to upstream code.

How this works

Note that #872 results in all upstream types / vars / consts being in the imports.go file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths.

  1. Globally change all imports from coreth/core/types to libevm/core/types;
  2. Rename all coreth/core/types imports to customtypes for ease of review here;
  3. Dot import libevm/core/types in tests only to avoid hundreds of noisy changes.

Note

This is part of a chain of PRs and will have its base changed once #872 is merged. The chain is split so that each one is "obviously" correct. I will not consider any review changes that deviate from this simplicity—if this is an issue, please explain why and add a "Do not merge" label.

How this was tested

CI of existing tests.

Need to be documented?

No

Need to update RELEASES.md?

No

@ARR4N ARR4N mentioned this pull request Mar 14, 2025
Merged
@ARR4N ARR4N marked this pull request as ready for review March 14, 2025 11:54
@ARR4N ARR4N requested review from a team, ceyonur and darioush as code owners March 14, 2025 11:54
qdm12
qdm12 approved these changes Mar 14, 2025
View reviewed changes
Base automatically changed from arr4n/remove-libevm-type-identities to libevm March 14, 2025 15:05
darioush
darioush approved these changes Mar 14, 2025
View reviewed changes
@ARR4N ARR4N enabled auto-merge (squash) March 14, 2025 18:05
@ARR4N ARR4N merged commit 197a784 into libevm Mar 14, 2025
6 checks passed
@ARR4N ARR4N deleted the arr4n/upstream-core-types branch March 14, 2025 18:14
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Mar 19, 2025
@ARR4N @qdm12
refactor: use upstream core/types
e374788 
Complete the transition of `core/types` to upstream code.

Note that the previous commit results in _all_ upstream types / vars / consts being in the `imports.go` file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths.

1. Globally change all imports from `subnet-evm/core/types` to `libevm/core/types`;
2. Rename all `subnet-evm/core/types` imports to `customtypes` for ease of review here;
3. Dot import `libevm/core/types` in tests only to avoid hundreds of noisy changes.

See original PR ava-labs/coreth#875
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Mar 19, 2025
@ARR4N @qdm12
refactor: use upstream core/types
ddeda31 
Complete the transition of `core/types` to upstream code.

Note that the previous commit results in _all_ upstream types / vars / consts being in the `imports.go` file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths.

1. Globally change all imports from `subnet-evm/core/types` to `libevm/core/types`;
2. Rename all `subnet-evm/core/types` imports to `customtypes` for ease of review here;
3. Dot import `libevm/core/types` in tests only to avoid hundreds of noisy changes.

See original PR ava-labs/coreth#875
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Mar 21, 2025
@ARR4N @qdm12
refactor: use upstream core/types
1bd45dd 
Complete the transition of `core/types` to upstream code.

Note that the previous commit results in _all_ upstream types / vars / consts being in the `imports.go` file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths.

1. Globally change all imports from `subnet-evm/core/types` to `libevm/core/types`;
2. Rename all `subnet-evm/core/types` imports to `customtypes` for ease of review here;
3. Dot import `libevm/core/types` in tests only to avoid hundreds of noisy changes.

See original PR ava-labs/coreth#875
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Mar 21, 2025
@ARR4N @qdm12
refactor: use upstream core/types
327391b 
Complete the transition of `core/types` to upstream code.

Note that the previous commit results in _all_ upstream types / vars / consts being in the `imports.go` file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths.

1. Globally change all imports from `subnet-evm/core/types` to `libevm/core/types`;
2. Rename all `subnet-evm/core/types` imports to `customtypes` for ease of review here;
3. Dot import `libevm/core/types` in tests only to avoid hundreds of noisy changes.

See original PR ava-labs/coreth#875
qdm12 pushed a commit that referenced this pull request Mar 24, 2025
@ARR4N @qdm12
refactor: use upstream core/types (#875)
52c0534 
## Why this should be merged

Complete the transition of `core/types` to upstream code.

## How this works

Note that #872 results in _all_ upstream types / vars / consts being in the `imports.go` file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths.

1. Globally change all imports from `coreth/core/types` to `libevm/core/types`;
2. Rename all `coreth/core/types` imports to `customtypes` for ease of review here;
3. Dot import `libevm/core/types` in tests only to avoid hundreds of noisy changes.
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Mar 24, 2025
@ARR4N @qdm12
refactor: use upstream core/types
766459a 
Complete the transition of `core/types` to upstream code.

Note that the previous commit results in _all_ upstream types / vars / consts being in the `imports.go` file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths.

1. Globally change all imports from `subnet-evm/core/types` to `libevm/core/types`;
2. Rename all `subnet-evm/core/types` imports to `customtypes` for ease of review here;
3. Dot import `libevm/core/types` in tests only to avoid hundreds of noisy changes.

See original PR ava-labs/coreth#875
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Mar 24, 2025
@ARR4N @qdm12
refactor: use upstream core/types
4537a21 
Complete the transition of `core/types` to upstream code.

Note that the previous commit results in _all_ upstream types / vars / consts being in the `imports.go` file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths.

1. Globally change all imports from `subnet-evm/core/types` to `libevm/core/types`;
2. Rename all `subnet-evm/core/types` imports to `customtypes` for ease of review here;
3. Dot import `libevm/core/types` in tests only to avoid hundreds of noisy changes.

See original PR ava-labs/coreth#875
qdm12 pushed a commit that referenced this pull request Mar 24, 2025
@ARR4N @qdm12
refactor: use upstream core/types (#875)
eae4e7a 
## Why this should be merged

Complete the transition of `core/types` to upstream code.

## How this works

Note that #872 results in _all_ upstream types / vars / consts being in the `imports.go` file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths.

1. Globally change all imports from `coreth/core/types` to `libevm/core/types`;
2. Rename all `coreth/core/types` imports to `customtypes` for ease of review here;
3. Dot import `libevm/core/types` in tests only to avoid hundreds of noisy changes.
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Mar 24, 2025
@ARR4N @qdm12
refactor: use upstream core/types
5241b75 
Complete the transition of `core/types` to upstream code.

Note that the previous commit results in _all_ upstream types / vars / consts being in the `imports.go` file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths.

1. Globally change all imports from `subnet-evm/core/types` to `libevm/core/types`;
2. Rename all `subnet-evm/core/types` imports to `customtypes` for ease of review here;
3. Dot import `libevm/core/types` in tests only to avoid hundreds of noisy changes.

See original PR ava-labs/coreth#875
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Mar 28, 2025
@ARR4N @qdm12
refactor: use upstream core/types
843d321 
Complete the transition of `core/types` to upstream code.

Note that the previous commit results in _all_ upstream types / vars / consts being in the `imports.go` file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths.

1. Globally change all imports from `subnet-evm/core/types` to `libevm/core/types`;
2. Rename all `subnet-evm/core/types` imports to `customtypes` for ease of review here;
3. Dot import `libevm/core/types` in tests only to avoid hundreds of noisy changes.

See original PR ava-labs/coreth#875
qdm12 pushed a commit to ava-labs/subnet-evm that referenced this pull request Apr 1, 2025
@ARR4N @qdm12
refactor: use upstream core/types
b45b79a 
Complete the transition of `core/types` to upstream code.

Note that the previous commit results in _all_ upstream types / vars / consts being in the `imports.go` file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths.

1. Globally change all imports from `subnet-evm/core/types` to `libevm/core/types`;
2. Rename all `subnet-evm/core/types` imports to `customtypes` for ease of review here;
3. Dot import `libevm/core/types` in tests only to avoid hundreds of noisy changes.

See original PR ava-labs/coreth#875
@qdm12 qdm12 mentioned this pull request Apr 8, 2025
Merged
node-druidx56y added a commit to node-druidx56y/subnet-evm that referenced this pull request Sep 28, 2025
@node-druidx56y
refactor: use upstream core/types
0b92a12 
Complete the transition of `core/types` to upstream code.

Note that the previous commit results in _all_ upstream types / vars / consts being in the `imports.go` file. This results in a strict partition of upstream and local identifiers so it is safe to simply change import paths.

1. Globally change all imports from `subnet-evm/core/types` to `libevm/core/types`;
2. Rename all `subnet-evm/core/types` imports to `customtypes` for ease of review here;
3. Dot import `libevm/core/types` in tests only to avoid hundreds of noisy changes.

See original PR ava-labs/coreth#875
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michaelkaplan13 michaelkaplan13 michaelkaplan13 approved these changes

@ceyonur ceyonur Awaiting requested review from ceyonur ceyonur is a code owner

+2 more reviewers

@qdm12 qdm12 qdm12 approved these changes

@darioush darioush darioush approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ARR4N @darioush @qdm12 @michaelkaplan13