fix(amazonq): implement logic so aws/chat/openTab returns correct tabID to server #5658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ions' into samsgt/q-lsp-chat-openTab-impl
manodnyab
reviewed
Apr 30, 2025
| companion object { | ||
| private val LOG = getLogger<AmazonQLanguageClientImpl>() | ||
|
|
||
| private val pendingTabRequests = ConcurrentHashMap<String, CompletableFuture<OpenTabResult>>() |
There was a problem hiding this comment.
Why can't this be a queue/list?
There was a problem hiding this comment.
I don't understand why/how that would be better here.
There was a problem hiding this comment.
Instead of here, can we maintain this as part of the chat communication manager since that's a service?
There was a problem hiding this comment.
good idea. done
Qodana Community for JVMIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
6 tasks
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...c/software/aws/toolkits/jetbrains/services/amazonq/lsp/flareChat/ChatCommunicationManager.kt
Fixed
Show fixed
Hide fixed
manodnyab
approved these changes
May 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a requestID to the browser message that we post from this request.
a hashmap is used to track requestID's to the result that will be returned.
To match VSC a 30 second timeout is added in case the browser does not return the message.
Types of changes
Description
Checklist
License
I confirm that my contribution is made under the terms of the Apache 2.0 license.