-
Notifications
You must be signed in to change notification settings - Fork 273
fix(amazonq): implement logic so aws/chat/openTab returns correct tabID to server #5658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
samgst-amazon
merged 17 commits into
feature/q-lsp-chat
from
samsgt/q-lsp-chat-openTab-impl
May 2, 2025
Merged
Changes from 9 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
29c7b1b
send openTab to browser
samgst-amazon 2aea952
Merge branch 'feature/q-lsp-chat' into samsgt/q-lsp-chat-openTab-impl
samgst-amazon d90e230
initial
manodnyab 1a98ffe
Merge remote-tracking branch 'origin/feature/q-lsp-chat' into manodny…
manodnyab 7a8cb71
Show options to for chat history and export in tab bar
manodnyab 83e7e5f
Merge remote-tracking branch 'refs/remotes/origin/manodnyb/addChatOpt…
samgst-amazon 7483217
add requestID and mapping
samgst-amazon 84fabbc
detekt
samgst-amazon ca8decb
remove println
samgst-amazon 2fc63c1
Merge branch 'feature/q-lsp-chat' into samsgt/q-lsp-chat-openTab-impl
samgst-amazon 0fbc5c5
move tab request map into ChatCommunicationManager
samgst-amazon 11efa24
Merge branch 'feature/q-lsp-chat' into samsgt/q-lsp-chat-openTab-impl
samgst-amazon 8fc2023
Merge branch 'feature/q-lsp-chat' into samsgt/q-lsp-chat-openTab-impl
samgst-amazon e7c7dbc
refactor for consistency
samgst-amazon bec7436
detekt
samgst-amazon 861b201
Merge branch 'feature/q-lsp-chat' into samsgt/q-lsp-chat-openTab-impl
samgst-amazon 310357c
detekt
samgst-amazon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why can't this be a queue/list?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand why/how that would be better here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of here, can we maintain this as part of the chat communication manager since that's a service?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good idea. done