-
Notifications
You must be signed in to change notification settings - Fork 738
fix(lambda): remove template path from sam deploy command #5912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
/runIntegrationTests |
roger-zhangg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
/runIntegrationTests |
hayemaxi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm pending integration tests
|
Looking into Intg test failures |
hayemaxi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
integ tests need fixing
|
The integration tests failures do not seem to be related to the new change introduced in this PR but more like false negative resulted from issue with mocking. |
Problem
Explicitly specifying template path in sam deploy command to point to the build artifact folder makes SAM CLI create/update
samconfig.tomlin the build artifact folder rather than updating thesamconfig.tomlfile in project root folder.Solution
Remove the
--template-pathfrom deploy flag. SAM will determine the template in the project folder and write to correct samconfig fileLicense: I confirm that my contribution is made under the terms of the Apache 2.0 license.