Skip to content

Conversation

@vicheey
Copy link
Contributor

@vicheey vicheey commented Nov 1, 2024

Problem

Explicitly specifying template path in sam deploy command to point to the build artifact folder makes SAM CLI create/update samconfig.toml in the build artifact folder rather than updating the samconfig.toml file in project root folder.

Solution

Remove the --template-path from deploy flag. SAM will determine the template in the project folder and write to correct samconfig file


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

@github-actions
Copy link

github-actions bot commented Nov 1, 2024

  • This pull request implements a feat or fix, so it must include a changelog entry (unless the fix is for an unreleased feature). Review the changelog guidelines.
    • Note: beta or "experiment" features that have active users should announce fixes in the changelog.
    • If this is not a feature or fix, use an appropriate type from the title guidelines. For example, telemetry-only changes should use the telemetry type.

@vicheey
Copy link
Contributor Author

vicheey commented Nov 1, 2024

/runIntegrationTests

@vicheey vicheey marked this pull request as ready for review November 1, 2024 16:23
@vicheey vicheey requested a review from a team as a code owner November 1, 2024 16:23
Copy link
Member

@roger-zhangg roger-zhangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hayemaxi
Copy link
Contributor

hayemaxi commented Nov 1, 2024

/runIntegrationTests

Copy link
Contributor

@hayemaxi hayemaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm pending integration tests

@vicheey
Copy link
Contributor Author

vicheey commented Nov 1, 2024

Looking into Intg test failures

Copy link
Contributor

@hayemaxi hayemaxi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

integ tests need fixing

@vicheey
Copy link
Contributor Author

vicheey commented Nov 1, 2024

The integration tests failures do not seem to be related to the new change introduced in this PR but more like false negative resulted from issue with mocking.

@justinmk3 justinmk3 merged commit c1b76df into aws:master Nov 3, 2024
26 of 31 checks passed
@vicheey vicheey deleted the fix-sam-deploy-save-param branch November 4, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants