feat(amazonq): pre-fetch next recommendations for inline completions #6419
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
zixlin7
requested review from
Will-ShaoHua,
andrewyuq,
evanliu048 and
leigaol
Will-ShaoHua
approved these changes
Feb 3, 2025
hayemaxi
reviewed
Feb 4, 2025
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "type": "Feature", | |||
| "description": "prefetch next recommendations when possible to reduce suggestion latency" | |||
Contributor
There was a problem hiding this comment.
Suggested change
| "description": "prefetch next recommendations when possible to reduce suggestion latency" | |
| "description": "Inline suggestions: Pre-fetch recommendations to reduce suggestion latency." |
hayemaxi
reviewed
Feb 4, 2025
Comment on lines
21
to
23
| describe('onAcceptance', function () { | ||
| beforeEach(async function () { | ||
| const session = CodeWhispererSessionState.instance.getSession() |
Contributor
There was a problem hiding this comment.
Suggested change
| describe('onAcceptance', function () { | |
| beforeEach(async function () { | |
| const session = CodeWhispererSessionState.instance.getSession() | |
| const session = CodeWhispererSessionState.instance.getSession() | |
| describe('onAcceptance', function () { | |
| beforeEach(async function () { |
Does the variable need to be duplicated? Applicable throughout PR (for tests).
Contributor
There was a problem hiding this comment.
yes that's a good callout, thanks Max
hayemaxi
reviewed
Feb 4, 2025
| firstSuggestionShowTime = 0 | ||
| perceivedLatency = 0 | ||
| // Per-session states | ||
| constructor() { |
Contributor
There was a problem hiding this comment.
Can you just initialize all these directly in the class definition above? It would cut the amount of code in half and still be understandable.
Contributor
There was a problem hiding this comment.
yea that sounds good tome
Contributor
|
fixing CI failure |
This was referenced Feb 11, 2025
evanliu048
added a commit
to evanliu048/aws-toolkit-vscode
that referenced
this pull request
Feb 12, 2025
s7ab059789
pushed a commit
to s7ab059789/aws-toolkit-vscode
that referenced
this pull request
Feb 19, 2025
…ws#6419) ## Problem To support complex recommendations broken into multiple chunks, we need the ability to immediately show user next recommendation when they accept previous one ## Solution pre-fetch next recommendation predicting user accept first recommendation when showing them to user, and if user did accept first recommendation, immediately show next recommendation --- - Treat all work as PUBLIC. Private `feature/x` branches will not be squash-merged at release time. - Your code changes must meet the guidelines in [CONTRIBUTING.md](https://github.com/aws/aws-toolkit-vscode/blob/master/CONTRIBUTING.md#guidelines). - License: I confirm that my contribution is made under the terms of the Apache 2.0 license. --------- Co-authored-by: Will Lo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
To support complex recommendations broken into multiple chunks, we need the ability to immediately show user next recommendation when they accept previous one
Solution
pre-fetch next recommendation predicting user accept first recommendation when showing them to user, and if user did accept first recommendation, immediately show next recommendation
feature/xbranches will not be squash-merged at release time.