-
-
Notifications
You must be signed in to change notification settings - Fork 638
revert(pypi): revert the default for pipstar #3373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request reverts a previous change, setting the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request reverts the default setting for pipstar, disabling it by default. The code change in python/private/internal_config_repo.bzl is correct. However, the accompanying update to CHANGELOG.md is confusing and contains an error, stating that pipstar can be enabled with RULES_PYTHON_ENABLE_PIPSTAR=0, which is incorrect. I've provided a suggestion to clarify the changelog entry and correct the environment variable value to 1 for enabling the feature.
|
Ah, I'll need to do some extra fixes for unit tests. |
A user mentioned that flipping the pipstar default caused a regression in their setup in [this comment]. Until we have a better understanding and a regression test for that, we should revert the flip. Adjusted the CHANGELOG notes for this. Related to #2949 [this comment]: #2949 (comment) (cherry picked from commit 3c3e0be)
A user mentioned that flipping the pipstar default caused
a regression in their setup in this comment. Until we have
a better understanding and a regression test for that, we should
revert the flip. Adjusted the CHANGELOG notes for this.
Related to #2949