Skip to content

Conversation

@aignas
Copy link
Collaborator

@aignas aignas commented Oct 21, 2025

A user mentioned that flipping the pipstar default caused
a regression in their setup in this comment. Until we have
a better understanding and a regression test for that, we should
revert the flip. Adjusted the CHANGELOG notes for this.

Related to #2949

@aignas aignas requested a review from rickeylev as a code owner October 21, 2025 05:17
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @aignas, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previous change, setting the pipstar feature to be disabled by default instead of enabled. This ensures that users must explicitly opt-in to use pipstar by setting the RULES_PYTHON_ENABLE_PIPSTAR environment variable, providing more control over its adoption and aligning with the intent of issue #2949.

Highlights

  • Revert pipstar Default: The default value for the pipstar flag has been reverted from enabled ("1") to disabled ("0"), meaning pipstar is no longer enabled by default.
  • Changelog Update: The CHANGELOG.md entry for the pipstar flag has been updated to accurately reflect its new default state and clarify how to enable it using the RULES_PYTHON_ENABLE_PIPSTAR environment variable.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reverts the default setting for pipstar, disabling it by default. The code change in python/private/internal_config_repo.bzl is correct. However, the accompanying update to CHANGELOG.md is confusing and contains an error, stating that pipstar can be enabled with RULES_PYTHON_ENABLE_PIPSTAR=0, which is incorrect. I've provided a suggestion to clarify the changelog entry and correct the environment variable value to 1 for enabling the feature.

@aignas
Copy link
Collaborator Author

aignas commented Oct 21, 2025

Ah, I'll need to do some extra fixes for unit tests.

@aignas aignas added this pull request to the merge queue Oct 24, 2025
Merged via the queue into bazel-contrib:main with commit 3c3e0be Oct 24, 2025
4 checks passed
@aignas aignas deleted the aignas.revert.pipstar-flag branch October 24, 2025 07:59
@rickeylev rickeylev mentioned this pull request Oct 28, 2025
17 tasks
rickeylev pushed a commit that referenced this pull request Oct 29, 2025
A user mentioned that flipping the pipstar default caused
a regression in their setup in [this comment]. Until we have
a better understanding and a regression test for that, we should
revert the flip. Adjusted the CHANGELOG notes for this.

Related to #2949

[this comment]:
#2949 (comment)

(cherry picked from commit 3c3e0be)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants