Fix headers: cv_bridge.hpp migration & gmock include cleanup#780
Open
maeri18 wants to merge 1 commit intobdaiinstitute:mainfrom
Open
Fix headers: cv_bridge.hpp migration & gmock include cleanup#780maeri18 wants to merge 1 commit intobdaiinstitute:mainfrom
maeri18 wants to merge 1 commit intobdaiinstitute:mainfrom
Conversation
…eleted gmock-generated-matchers.h import in matchers.hpp file, as gmock-generated-matchers is not part of new versions of gmock Signed-off-by: maeri18 <maevachekma@gmail.com>
Collaborator
|
Hi @maeri18, sorry for the delayed response! These changes don't build locally on Humble, so we should not merge this into main -- Is this intended for a newer distro of ROS? |
Author
Hello, @khughes-bdai |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Overview