Skip to content

Fix headers: cv_bridge.hpp migration & gmock include cleanup#780

Open
maeri18 wants to merge 1 commit intobdaiinstitute:mainfrom
maeri18:main
Open

Fix headers: cv_bridge.hpp migration & gmock include cleanup#780
maeri18 wants to merge 1 commit intobdaiinstitute:mainfrom
maeri18:main

Conversation

@maeri18
Copy link

@maeri18 maeri18 commented Dec 30, 2025

Change Overview

  • changed cv_bridge.h imports to cv_bridge.hpp imports in these files :
  1. spot_driver/src/api/default_image_client.cpp
  2. spot_driver/src/conversions/decompress_images.cpp
  3. spot_driver/src/image_stitcher/image_stitcher.cpp
  • Commented gmock-generated-matchers.h import in spot_driver/test/include/spot_driver/matchers.hpp, as gmock-generated-matchers is not part of new versions of gmock.

…eleted gmock-generated-matchers.h import in matchers.hpp file, as gmock-generated-matchers is not part of new versions of gmock

Signed-off-by: maeri18 <maevachekma@gmail.com>
@khughes-bdai
Copy link
Collaborator

Hi @maeri18, sorry for the delayed response! These changes don't build locally on Humble, so we should not merge this into main --

Starting >>> spot_driver
--- stderr: spot_driver                                      
/.../spot_ros2/spot_driver/src/api/default_image_client.cpp:9:10: fatal error: cv_bridge/cv_bridge.hpp: No such file or directory
    9 | #include <cv_bridge/cv_bridge.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Is this intended for a newer distro of ROS?

@maeri18
Copy link
Author

maeri18 commented Jan 28, 2026

Hi @maeri18, sorry for the delayed response! These changes don't build locally on Humble, so we should not merge this into main --

Starting >>> spot_driver
--- stderr: spot_driver                                      
/.../spot_ros2/spot_driver/src/api/default_image_client.cpp:9:10: fatal error: cv_bridge/cv_bridge.hpp: No such file or directory
    9 | #include <cv_bridge/cv_bridge.hpp>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.

Is this intended for a newer distro of ROS?

Hello, @khughes-bdai
Thank you for reviewing the pull request. Yes, this is intended for ros2 Jazzy.
I made these changes because I ran into errors around the mentioned file imports while trying to use the spot ros2 driver in a docker (Ubuntu 24.04 + ros2 jazzy) environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants