Skip to content

Simplify UI tests #20512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Aug 12, 2025
Merged

Simplify UI tests #20512

merged 11 commits into from
Aug 12, 2025

Conversation

ickshonpe
Copy link
Contributor

@ickshonpe ickshonpe commented Aug 11, 2025 •
edited
Loading

Objective

Simplify UI tests by replacing camera_system in the test schedule.

Should remove the need for the bevy_render dependency in #20502.

Solution

New update_cameras_test_system system that updates each Camera's render target info directly for UI tests without needing the extra dependencies and resource inits.

Testing

Run the tests.

@ickshonpe
Added a system to update the ComputedNodeTargets during UI layout t…
6718daa 
…ests so they don't need to use `Camera`s and `Window`s.
@ickshonpe
Added update_cameras_test_system to update cameras for UI tests wit…
6be76ba 
…hout needing the `ManualTextureViews` resource.
@ickshonpe ickshonpe mentioned this pull request Aug 11, 2025
Merged
@ickshonpe ickshonpe added A-UI Graphical user interfaces, styles, layouts, and widgets C-Testing A change that impacts how we test Bevy or how users test their apps D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Needs-Review Needs reviewer attention (from anyone!) to move forward A-Camera User-facing camera APIs and controllers. A-Windowing Platform-agnostic interface layer to run your app in labels Aug 11, 2025
@ickshonpe ickshonpe added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels Aug 12, 2025
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 12, 2025
@alice-i-cecile
Copy link
Member

@ickshonpe ping me when merge conflicts are resolved :)

@ickshonpe
Copy link
Contributor Author

@alice-i-cecile should be ready to go now

@alice-i-cecile alice-i-cecile added this pull request to the merge queue Aug 12, 2025
Merged via the queue into bevyengine:main with commit 2ba758e Aug 12, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristoff3r kristoff3r kristoff3r approved these changes

@tychedelia tychedelia tychedelia approved these changes

Assignees
No one assigned
Labels
A-Camera User-facing camera APIs and controllers. A-UI Graphical user interfaces, styles, layouts, and widgets A-Windowing Platform-agnostic interface layer to run your app in C-Testing A change that impacts how we test Bevy or how users test their apps D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ickshonpe @alice-i-cecile @kristoff3r @tychedelia