[FIX] Remove pyqt5 install magic#6153
Merged
markotoplak merged 2 commits intobiolab:masterfrom Nov 28, 2022
Merged
Conversation
Now there is also pyqt6 and we still force our users to also install PyQt5. This trick we had is also dangerous because it behaves differently with wheels and source installs.
3 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6153 +/- ##
==========================================
+ Coverage 86.49% 86.70% +0.21%
==========================================
Files 315 316 +1
Lines 67797 68058 +261
==========================================
+ Hits 58640 59009 +369
+ Misses 9157 9049 -108 |
Contributor
|
🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now there is also pyqt6 and we still force our users to also install PyQt5. This trick we had is also dangerous because it behaves differently with wheels and source installs.
Reverts #5593.
After merging this PR please also consider: biolab/orange-hugo#330