-
Notifications
You must be signed in to change notification settings - Fork 901
6 More Python Examples + Standardized Notebook Format #2288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6 More Python Examples + Standardized Notebook Format #2288
Conversation
dellaert
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome. Many thanks !!!!
Three requests:
- the copyright cells are nice, but please add a cell tag "remove-cell" with the
...menu. - It would be nice the have an "Open in colab" button, like this in this example
- That file also has a cell, again not shown on website as it has a "remove-cell" tag, that says:
try:
import google.colab
%pip install --quiet gtsam-develop
except ImportError:
pass
Can you add that as well for Colab?
The easiest way is probably to copy the json and work in raw json, copying from the example I gave.
|
@dellaert I made the requested changes. I added a script I ran the script on all the notebooks in the |
…re/more_translated_python_examples
|
Updated, script has been run on all of |
|
Incredible! Merging. (CI is irrelevant here) |
Hello!
I did a deep dive into the GTSAM codebase and translated some examples from C++ to Python that haven't been done already - I also did my best to explain them in notebook format.
Additionally, I updated the README to check off files I saw implemented already.
Converted examples:
CreateSFMExampleData.cpp->CreateSFMExampleData.ipynbDiscreteBayesNetExample.cpp->DiscreteBayesNetExample.ipynbFisheyeExample.cpp->FisheyeExample.ipynbHMMExample.cpp->HMMExample.ipynbPose2SLAMwSPCG.cpp->Pose2SLAMwSPCG.ipynbPose2SLAMStressTest.cpp->Pose2SLAMStressTest.ipynbOne thing I noticed were that ExpressionFactorGraph (and maybe some of the auto differentiation framework) is not exposed yet in Python, so I wasn't able to convert that example. I noted this in the README and would be happy to tackle adding this in the future. Other than
Pose2SLAMExampleExpressionsandPose2SLAMExample_lago, all the Pose2 examples are now translated.