Skip to content

TBB for solve #2336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dellaert merged 6 commits into from
Jan 4, 2026
Merged

TBB for solve #2336

dellaert merged 6 commits into from
Jan 4, 2026
+189 −134

Conversation

@dellaert
Copy link
Member

@dellaert dellaert commented Jan 3, 2026 •
edited
Loading

Now also uses TBB for back-substitution.
Some other improvements:

  • Switched blockIndex_ to vector as probably faster for small # keys
  • refactored 3 identical sumDims copy/pasta
  • Pass separator keys as set to clique constructor without converting

@dellaert dellaert requested review from ProfFan and Copilot January 3, 2026 21:08
Copilot AI reviewed Jan 3, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@dellaert dellaert requested a review from Copilot January 3, 2026 22:08
Copilot AI reviewed Jan 3, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

@dellaert dellaert merged commit ec51716 into develop Jan 4, 2026
33 of 34 checks passed
@dellaert dellaert deleted the feature/parallelSolve branch January 4, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ProfFan ProfFan ProfFan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dellaert @ProfFan