Fix LSP symbol resolve on missing rpc types #4258
Merged
+24
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
doriable
reviewed
Jan 5, 2026
private/buf/buflsp/file.go
Outdated
| def: output.AST(), // Only messages can be method inputs and outputs | ||
| fullName: output.FullName(), | ||
| }, | ||
| if astOutputs := irSymbol.AsMethod().AST().AsMethod().Signature.Outputs(); !astOutputs.IsZero() { |
Member
There was a problem hiding this comment.
I think this should actually be a check on astOutputs.Len() > 0, since all AST accessors already have zero value checks on them (e.g. https://github.com/bufbuild/protocompile/blob/4d8d90b1c6b81a3d7cbd55df836c33b55d0c88c6/experimental/ast/type_generic.go#L147)
doriable
approved these changes
Jan 6, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a panic on an invalid file where the
rpcmethod has an empty request or response type.