Skip to content

Fix LSP symbol resolve on missing rpc types #4258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emcfarlane merged 2 commits into from
Jan 6, 2026
+24 −21
Merged

Fix LSP symbol resolve on missing rpc types #4258

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b880850
Fix LSP symbol resolve on missing rpc types
emcfarlane Jan 5, 2026
4a96c84
Assert len == 1
emcfarlane Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 24 additions & 21 deletions private/buf/buflsp/file.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -629,31 +629,34 @@ func (f *file) irToSymbols(irSymbol ir.Symbol) ([]*symbol, []*symbol) {

input, _ := irSymbol.AsMethod().Input()
// Method input must be a single message type.
inputAST := irSymbol.AsMethod().AST().AsMethod().Signature.Inputs().At(0)
inputSym := &symbol{
ir: irSymbol,
file: f,
span: inputAST.RemovePrefixes().Span(), // We always strip prefixes in case of streaming.
kind: &reference{
def: input.AST(), // Only messages can be method inputs and outputs
fullName: input.FullName(),
},
if astInputs := irSymbol.AsMethod().AST().AsMethod().Signature.Inputs(); astInputs.Len() == 1 {
inputAST := astInputs.At(0)
inputSym := &symbol{
ir: irSymbol,
file: f,
span: inputAST.RemovePrefixes().Span(), // We always strip prefixes in case of streaming.
kind: &reference{
def: input.AST(), // Only messages can be method inputs and outputs
fullName: input.FullName(),
},
}
unresolved = append(unresolved, inputSym)
}
unresolved = append(unresolved, inputSym)

output, _ := irSymbol.AsMethod().Output()
// Method output must be a single message type.
outputAST := irSymbol.AsMethod().AST().AsMethod().Signature.Outputs().At(0)
outputSym := &symbol{
ir: irSymbol,
file: f,
span: outputAST.RemovePrefixes().Span(), // We always strip prefixes in case of streaming.
kind: &reference{
def: output.AST(), // Only messages can be method inputs and outputs
fullName: output.FullName(),
},
if astOutputs := irSymbol.AsMethod().AST().AsMethod().Signature.Outputs(); astOutputs.Len() == 1 {
outputAST := astOutputs.At(0)
outputSym := &symbol{
ir: irSymbol,
file: f,
span: outputAST.RemovePrefixes().Span(), // We always strip prefixes in case of streaming.
kind: &reference{
def: output.AST(), // Only messages can be method inputs and outputs
fullName: output.FullName(),
},
}
unresolved = append(unresolved, outputSym)
}
unresolved = append(unresolved, outputSym)
unresolved = append(unresolved, f.messageToSymbols(irSymbol.AsMethod().Options())...)
}
return resolved, unresolved
Expand Down